Issue 4274069: code review 4274069: filepath: do not run TestEvalSymlinks on Windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4274069: code review 4274069: filepath: do not run TestEvalSymlinks on Windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by brainman

Modified:
14 years, 1 month ago

Reviewers:

CC:
golang-dev, rsc1, adg

Visibility:
Public.

Description

filepath: do not run TestEvalSymlinks on Windows

Patch Set 1 #

Patch Set 2 : diff -r be3f3287a5b0 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r be3f3287a5b0 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r be3f3287a5b0 https://go.googlecode.com/hg/ #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/pkg/path/filepath/path_test.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com (cc: adg), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2011-03-17 22:58:45 UTC) #1

brainman

*** Submitted as http://code.google.com/p/go/source/detail?r=35153fc8dd30 *** filepath: do not run TestEvalSymlinks on Windows R=golang-dev, rsc1 CC=adg, ...

14 years, 1 month ago (2011-03-17 23:19:24 UTC) #3

brainman

On 2011/03/17 23:17:11, rsc1 wrote: > LGTM Thank you Russ.

14 years, 1 month ago (2011-03-17 23:19:55 UTC) #4

adg

14 years, 1 month ago (2011-03-18 05:46:52 UTC) #5

Thanks Alex.

On 18 March 2011 09:58,  <alex.brainman@gmail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: adg),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> filepath: do not run TestEvalSymlinks on Windows
>
> Please review this at http://codereview.appspot.com/4274069/
>
> Affected files:
>  M src/pkg/path/filepath/path_test.go
>
>
> Index: src/pkg/path/filepath/path_test.go
> ===================================================================
> --- a/src/pkg/path/filepath/path_test.go
> +++ b/src/pkg/path/filepath/path_test.go
> @@ -440,6 +440,10 @@
>  }
>
>  func TestEvalSymlinks(t *testing.T) {
> +       // Symlinks are not supported under windows.
> +       if runtime.GOOS == "windows" {
> +               return
> +       }
>        defer os.RemoveAll("test")
>        for _, d := range EvalSymlinksTestDirs {
>                var err os.Error
>
>
>

Expand All Messages | Collapse All Messages