Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(174)

Issue 4274063: code review 4274063: testing: compile regexp only once (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by r
Modified:
14 years, 2 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

testing: compile regexp only once The -test.run and -test.bench flags were compilng the regexp for ever test function, which was mucking up memory profiles. Add a simple wrapper to save the compiled state so that the regexp is compiled only once for each flag.

Patch Set 1 #

Patch Set 2 : diff -r f99e5037f2d1 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M src/cmd/gotest/gotest View 2 chunks +21 lines, -5 lines 0 comments Download

Messages

Total messages: 3
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 2 months ago (2011-03-16 17:28:54 UTC) #1
rsc
LGTM
14 years, 2 months ago (2011-03-16 17:30:38 UTC) #2
r
14 years, 2 months ago (2011-03-16 17:32:24 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=786104c3c59b ***

testing: compile regexp only once
The -test.run and -test.bench flags were compilng the regexp for ever test
function, which was mucking up memory profiles.   Add a simple wrapper
to save the compiled state so that the regexp is compiled only once for
each flag.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4274063
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b