Doc: NR more examples to Repeats for beat slashes

Doc: NR more examples to Repeats for beat slashes

This is for Tracker Issue #1574

Showing short-duration repeats and beat slashes along with
mixed length notes.

[Neil Puttock, 2011-03-28 20:04:37]

Hi James,

Thanks for doing this.  It LGTM (but don't forget to remove the @knownissue)

Just two suggestions for you: a changes.itely entry is probably a good idea, and
the @seealso for the Internals Reference needs the following items added:

DoublePercentEvent
DoubleRepeatSlash
Double_percent_repeat_engraver
RepeatSlashEvent
Slash_repeat_engraver

Cheers,
Neil

http://codereview.appspot.com/4273125/diff/1/Documentation/notation/repeats.i...
File Documentation/notation/repeats.itely (right):

http://codereview.appspot.com/4273125/diff/1/Documentation/notation/repeats.i...
Documentation/notation/repeats.itely:583: \repeat percent 5 { c32 d e f}
f }

http://codereview.appspot.com/4273125/diff/1/Documentation/notation/repeats.i...
Documentation/notation/repeats.itely:584: \repeat percent 4 { c16 d e f}
f }

[Graham Percival (old account), 2011-03-28 21:13:40]

LTGM, and I agree with Neil's comments.

[pkx166h, 2011-03-28 21:47:42]

On 2011/03/28 20:04:37, Neil Puttock wrote:
> Hi James,
> 
> Thanks for doing this.  It LGTM (but don't forget to remove the @knownissue)

Thanks, I missed that. Done.

> 
> Just two suggestions for you: a changes.itely entry is probably a good idea, 

Yes. Done. Included in this patch as if this patch is reverted forany reason it
will also revert the changes.tely edits too.

and
> the @seealso for the Internals Reference needs the following items added:
> 
> DoublePercentEvent
> DoubleRepeatSlash
> Double_percent_repeat_engraver
> RepeatSlashEvent
> Slash_repeat_engraver

Thanks. Done.

[pkx166h, 2011-03-28 21:47:58]

Second Draft.

[Graham Percival (old account), 2011-03-28 22:03:27]

LGTM

[Neil Puttock, 2011-03-29 22:41:17]

http://codereview.appspot.com/4273125/diff/1002/Documentation/changes.tely
File Documentation/changes.tely (right):

http://codereview.appspot.com/4273125/diff/1002/Documentation/changes.tely#ne...
Documentation/changes.tely:65: Single beat repeats for sixteenth or shorter
notes and beat repeats for
A short snippet would be great here.

http://codereview.appspot.com/4273125/diff/1002/Documentation/notation/repeat...
File Documentation/notation/repeats.itely (right):

http://codereview.appspot.com/4273125/diff/1002/Documentation/notation/repeat...
Documentation/notation/repeats.itely:583: \repeat percent 5 { c32 d e f}
\repeat percent 5 { c32 d e f }

http://codereview.appspot.com/4273125/diff/1002/Documentation/notation/repeat...
Documentation/notation/repeats.itely:584: \repeat percent 4 { c16 d e f}
\repeat percent 4 { c16 d e f }

http://codereview.appspot.com/4273125/diff/1002/Documentation/notation/repeat...
Documentation/notation/repeats.itely:640: @rinternals{Slash_repeat_engraver}.
+ Percent_repeat_engraver

[pkx166h, 2011-03-30 14:20:56]

Draft #3 posted.

http://codereview.appspot.com/4273125/diff/1002/Documentation/changes.tely
File Documentation/changes.tely (right):

http://codereview.appspot.com/4273125/diff/1002/Documentation/changes.tely#ne...
Documentation/changes.tely:65: Single beat repeats for sixteenth or shorter
notes and beat repeats for
On 2011/03/29 22:41:17, Neil Puttock wrote:

Done.

I also went down the list a bit and made some minor spacing tweaks, to space out
the sections in the tely (no affect to final output) and reworded a couple of
lines as they were syntactically awkward to read.

http://codereview.appspot.com/4273125/diff/1002/Documentation/notation/repeat...
File Documentation/notation/repeats.itely (right):

http://codereview.appspot.com/4273125/diff/1002/Documentation/notation/repeat...
Documentation/notation/repeats.itely:583: \repeat percent 5 { c32 d e f}
On 2011/03/29 22:41:17, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4273125/diff/1002/Documentation/notation/repeat...
Documentation/notation/repeats.itely:584: \repeat percent 4 { c16 d e f}
On 2011/03/29 22:41:17, Neil Puttock wrote:

Done.

http://codereview.appspot.com/4273125/diff/1002/Documentation/notation/repeat...
Documentation/notation/repeats.itely:640: @rinternals{Slash_repeat_engraver}.
On 2011/03/29 22:41:17, Neil Puttock wrote:

Done.

[pkx166h, 2011-04-02 09:36:13]

anymore for anymore?

[pkx166h, 2011-04-02 09:36:14]

anymore for anymore?

[Graham Percival (old account), 2011-04-02 15:57:46]

LGTM

[pkx166h, 2011-04-04 10:38:03]

Pushed as commit

85fe0f15000f793435221fab2688ba3fa65a028f