Issue 4266044: code review 4266044: websocket: use httptest.Server for tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4266044: code review 4266044: websocket: use httptest.Server for tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by rh

Modified:
14 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

websocket: use httptest.Server for tests

Patch Set 2 : diff -r 6e0c3b77928a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6e0c3b77928a https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 6e0c3b77928a https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 6e0c3b77928a https://go.googlecode.com/hg/ #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	src/pkg/websocket/websocket_test.go	View	1 2 3	2 chunks	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 2 months ago (2011-03-06 21:51:01 UTC) #1

rsc

Thanks for fixing this. http://codereview.appspot.com/4266044/diff/4001/src/pkg/websocket/websocket_test.go File src/pkg/websocket/websocket_test.go (right): http://codereview.appspot.com/4266044/diff/4001/src/pkg/websocket/websocket_test.go#newcode28 src/pkg/websocket/websocket_test.go:28: server := httptest.NewServer(http.DefaultServeMux) s/http.DefaultServeMux/nil/

14 years, 2 months ago (2011-03-06 21:54:21 UTC) #2

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 2 months ago (2011-03-06 21:59:03 UTC) #3

rsc

14 years, 2 months ago (2011-03-06 22:05:16 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=45f77ba34e1d ***

websocket: use httptest.Server for tests

R=rsc
CC=golang-dev
http://codereview.appspot.com/4266044

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages