code review 4264049: goinstall: handle .s files with gc

goinstall: handle .s files with gc

As a data point, with this change goinstall is able to
fully build package big out of the box.

[niemeyer, 2011-03-07 16:30:13]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-03-07 16:35:24]

http://codereview.appspot.com/4264049/diff/4001/src/cmd/goinstall/make.go
File src/cmd/goinstall/make.go (right):

http://codereview.appspot.com/4264049/diff/4001/src/cmd/goinstall/make.go#new...
src/cmd/goinstall/make.go:70: cgoOFiles := make([]string, 0,
len(dirInfo.cFiles))
This is a significant change not mentioned in the CL description.
It means that goinstall assumes that .c files are to be compiled
with gcc as part of a cgo package, instead of compiled with 6c.
I am not sure about that.

[niemeyer, 2011-03-07 16:49:10]

http://codereview.appspot.com/4264049/diff/4001/src/cmd/goinstall/make.go
File src/cmd/goinstall/make.go (right):

http://codereview.appspot.com/4264049/diff/4001/src/cmd/goinstall/make.go#new...
src/cmd/goinstall/make.go:70: cgoOFiles := make([]string, 0,
len(dirInfo.cFiles))
Not really.  Nothing has changed in that regard, which is why it's not
mentioned.  It's just a variable name being renamed to reflect its actual usage.

We had already agreed before that .c files within a cgo package should be
compiled with gcc, and that is still the case with this CL.

I actually have another change ready in the pipeline which makes .c files be
compiled with gc when not using cgo.  I'll submit it for review once this one
goes in.

[rsc, 2011-03-07 17:00:59]

LGTM

[rsc, 2011-03-07 17:08:54]

*** Submitted as dffa61a0b2da ***

goinstall: handle .s files with gc

As a data point, with this change goinstall is able to
fully build package big out of the box.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4264049

Committer: Russ Cox <rsc@golang.org>