Issue 4261052: code review 4261052: http: change Hijacker to return a net.Conn

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4261052: code review 4261052: http: change Hijacker to return a net.Conn (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by bradfitz

Modified:
14 years, 2 months ago

Reviewers:

CC:
rsc, gburd, golang-dev

Visibility:
Public.

Description

http: change Hijacker to return a net.Conn net.Conn is itself a io.ReadWriteCloser, so most code should be unaffected.

Patch Set 2 : diff -r 86e3885a0f82 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 3 : diff -r af83aa41994c https://go.googlecode.com/hg/ #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
	M	src/pkg/http/server.go	View	1 2	2 chunks	+12 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello rsc, gburd (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 2 months ago (2011-03-07 19:48:05 UTC) #1

rsc

LGTM http://codereview.appspot.com/4261052/diff/1001/src/pkg/http/server.go File src/pkg/http/server.go (right): http://codereview.appspot.com/4261052/diff/1001/src/pkg/http/server.go#newcode86 src/pkg/http/server.go:86: // A Hijacker is an HTTP request which ...

14 years, 2 months ago (2011-03-07 19:51:29 UTC) #2

bradfitz

14 years, 2 months ago (2011-03-07 20:04:21 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=0faa20d2e2f4 ***

http: change Hijacker to return a net.Conn

net.Conn is itself a io.ReadWriteCloser, so
most code should be unaffected.

R=rsc, gburd
CC=golang-dev
http://codereview.appspot.com/4261052

Expand All Messages | Collapse All Messages