Issue 4261046: code review 4261046: cgo: use correct frame size for 0 arguments

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4261046: code review 4261046: cgo: use correct frame size for 0 arguments (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by rsc

Modified:
14 years, 2 months ago

Reviewers:

CC:
iant, golang-dev

Visibility:
Public.

Description

cgo: use correct frame size for 0 arguments Passing a frame size of 1 was causing the cgo callback to push 1 byte of arguments onto the stack, making the stack pointer misaligned, which had the effect of hiding all the pointers on the stack from the garbage collector. SWIG only wraps calls to C++ virtual methods, so it always has at least 1 argument, so SWIG does not need to be fixed too. Fixes issue 1328.

Patch Set 1 #

Patch Set 2 : diff -r eac39e39fc84 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r eac39e39fc84 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r fad2d06b2ff5 https://go.googlecode.com/hg/ #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	src/cmd/cgo/out.go	View	1	4 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 2 months ago (2011-03-04 20:58:29 UTC) #1

rsc

14 years, 2 months ago (2011-03-05 19:24:46 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=5c4996cd19d4 ***

cgo: use correct frame size for 0 arguments

Passing a frame size of 1 was causing the cgo callback
to push 1 byte of arguments onto the stack, making
the stack pointer misaligned, which had the effect of
hiding all the pointers on the stack from the garbage
collector.

SWIG only wraps calls to C++ virtual methods, so it
always has at least 1 argument, so SWIG does not need
to be fixed too.

Fixes issue 1328.

R=iant
CC=golang-dev
http://codereview.appspot.com/4261046

Expand All Messages | Collapse All Messages