Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2330)

Issue 4259050: Manual convert-ly woodwind files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by Keith
Modified:
13 years, 1 month ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Manual convert-ly woodwind files

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Documentation/notation/wind.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/snippets/new/woodwind-diagrams-listing.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/woodwind-diagrams-empty.ly View 1 chunk +1 line, -1 line 0 comments Download
M python/convertrules.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1
Keith
13 years, 2 months ago (2011-03-05 02:44:10 UTC) #1
The patch at http://codereview.appspot.com/4182071
requires changes to user input in case the user worked-around the old bug.

http://lists.gnu.org/archive/html/bug-lilypond/2010-12/msg00451.html

We want to flag code that could have a workaround like this:

e,4^\markup {
  \woodwind-diagram
    #'clarinet
    #'((cc . (one two three four five six))
       (lh . (thumb ))
       (rh . (ees)))  
  % ees instead of e to compensate for bug 
}

No files in lilypond git actually used the affected notes, so bump the version
number.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b