Issue 4253073: code review 4253073: crypto/ecdsa: add package.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4253073: code review 4253073: crypto/ecdsa: add package. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by agl1

Modified:
14 years, 2 months ago

Reviewers:

CC:
rsc, cw, golang-dev

Visibility:
Public.

Description

crypto/ecdsa: add package.

Patch Set 1 #

Patch Set 2 : diff -r ee5e80c62862 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1adc5588bf12 https://go.googlecode.com/hg/ #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+358 lines, -0 lines)			Patch
M	src/pkg/Makefile	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	src/pkg/crypto/ecdsa/Makefile	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
A	src/pkg/crypto/ecdsa/ecdsa.go	View	1 2	1 chunk	+128 lines, -0 lines	0 comments	Download
A	src/pkg/crypto/ecdsa/ecdsa_test.go	View	1	1 chunk	+218 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

LGTM please wrap the comments at top of ecdsa.go and add to pkg/Makefile.

14 years, 2 months ago (2011-03-10 02:37:31 UTC) #3

agl1

Hello rsc, cw (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 2 months ago (2011-03-10 14:42:32 UTC) #4

agl1

14 years, 2 months ago (2011-03-10 14:43:16 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=20246d5d70d2 ***

crypto/ecdsa: add package.

R=rsc, cw
CC=golang-dev
http://codereview.appspot.com/4253073

Expand All Messages | Collapse All Messages