Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4638)

Issue 4253061: Fix segfault from orphaned-lines code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by Keith
Modified:
13 years, 1 month ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Patch set 1 comes from http://codereview.appspot.com/4236047/ Patch set 2 applies the suggestions made there

Patch Set 1 #

Patch Set 2 : Apply suggestions from comments to 4236047 #

Total comments: 5

Patch Set 3 : apply Graham, Neil suggestions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -48 lines) Patch
M input/regression/markup-lines.ly View 1 2 1 chunk +38 lines, -26 lines 0 comments Download
M lily/paper-book.cc View 1 2 2 chunks +21 lines, -22 lines 0 comments Download

Messages

Total messages: 4
Graham Percival (old account)
LGTM, and thanks so much for working on this! http://codereview.appspot.com/4253061/diff/2001/input/regression/markup-lines.ly File input/regression/markup-lines.ly (right): http://codereview.appspot.com/4253061/diff/2001/input/regression/markup-lines.ly#newcode1 input/regression/markup-lines.ly:1: ...
13 years, 1 month ago (2011-03-07 13:12:32 UTC) #1
Neil Puttock
Hi Keith, LGTM. Can you put a \book { } block around all the \markuplines ...
13 years, 1 month ago (2011-03-07 22:21:22 UTC) #2
Keith
On 2011/03/07 22:21:22, Neil Puttock wrote: > > LGTM. > > Can you put a ...
13 years, 1 month ago (2011-03-08 03:05:08 UTC) #3
Graham Percival (old account)
13 years, 1 month ago (2011-03-10 12:08:29 UTC) #4
Ok, time's over with no objections.  Could you please push this?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b