Issue 4252057: code review 4252057: io: reimplement Pipe

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4252057: code review 4252057: io: reimplement Pipe (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by rsc

Modified:
13 years, 1 month ago

Reviewers:

CC:
iant, golang-dev

Visibility:
Public.

Description

io: reimplement Pipe No known bugs in the current pipe, but this one is simpler and easier to understand.

Patch Set 1 #

Patch Set 2 : diff -r eac39e39fc84 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5c4996cd19d4 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 1e2fbb6d948f https://go.googlecode.com/hg #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -212 lines)			Patch
	M	src/pkg/io/pipe.go	View	1	6 chunks	+89 lines, -212 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2011-03-05 19:30:54 UTC) #1

rsc

13 years, 1 month ago (2011-03-07 15:37:29 UTC) #3

*** Submitted as 7e7ceffb8515 ***

io: reimplement Pipe

No known bugs in the current pipe,
but this one is simpler and easier to
understand.

R=iant
CC=golang-dev
http://codereview.appspot.com/4252057

Expand All Messages | Collapse All Messages