Issue 4248078: code review 4248078: tls: move PeerCertificates to ConnectionState

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4248078: code review 4248078: tls: move PeerCertificates to ConnectionState (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by bradfitz

Modified:
14 years, 2 months ago

Reviewers:

CC:
agl, agl1, golang-dev, rsc

Visibility:
Public.

Description

tls: move PeerCertificates to ConnectionState

Patch Set 1 #

Patch Set 2 : diff -r 8392577a953b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8392577a953b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 017126f56520 https://go.googlecode.com/hg/ #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -9 lines)			Patch
	M	src/pkg/crypto/tls/common.go	View	1 2 3	2 chunks	+4 lines, -0 lines	0 comments	Download
	M	src/pkg/crypto/tls/conn.go	View	1	2 chunks	+1 line, -9 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello agl (cc: golang-dev@googlegroups.com, rsc), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 2 months ago (2011-03-10 15:18:00 UTC) #1

bradfitzgoog

Actually I just realized I lost some docs in the process. I'll move the old ...

14 years, 2 months ago (2011-03-10 15:19:38 UTC) #3

bradfitz

14 years, 2 months ago (2011-03-10 15:23:11 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=806b068f39b8 ***

tls: move PeerCertificates to ConnectionState

R=agl, agl1
CC=golang-dev, rsc
http://codereview.appspot.com/4248078

Expand All Messages | Collapse All Messages