Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(657)

Issue 4247070: code review 4247070: syscall: implement Mount and Unmount for linux. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by danderson
Modified:
13 years, 11 months ago
Reviewers:
CC:
bradfitz, bradfitzgoog, golang-dev
Visibility:
Public.

Description

syscall: implement Mount and Unmount for linux. Note that, while the final argument of mount(2) is a void*, in practice all filesystem implementations treat it as a string of comma-separated mount options.

Patch Set 1 #

Patch Set 2 : diff -r fbb39745c3f7a9bf23cfd8605a31bb42612611b1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r fbb39745c3f7a9bf23cfd8605a31bb42612611b1 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r fbb39745c3f7a9bf23cfd8605a31bb42612611b1 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r fbb39745c3f7a9bf23cfd8605a31bb42612611b1 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -0 lines) Patch
M src/pkg/syscall/mkerrors.sh View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/pkg/syscall/syscall_linux.go View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_linux_386.go View 1 5 chunks +22 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_linux_amd64.go View 1 5 chunks +22 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_linux_arm.go View 1 4 chunks +22 lines, -0 lines 0 comments Download
M src/pkg/syscall/zsyscall_linux_386.go View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download
M src/pkg/syscall/zsyscall_linux_amd64.go View 1 2 chunks +16 lines, -0 lines 0 comments Download
M src/pkg/syscall/zsyscall_linux_arm.go View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4
danderson
Hello bradfitzgo (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 2 months ago (2011-03-09 02:17:59 UTC) #1
danderson
On 2011/03/09 02:17:59, danderson wrote: > Hello bradfitzgo (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
14 years, 2 months ago (2011-03-09 02:34:24 UTC) #2
bradfitzgoog
LGTM Not sure where those two extra S_ constants came from, but presumably you just ...
14 years, 2 months ago (2011-03-09 13:58:33 UTC) #3
bradfitz
14 years, 2 months ago (2011-03-09 13:58:51 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=6e3dda8b91b3 ***

syscall: implement Mount and Unmount for linux.

Note that, while the final argument of mount(2) is a void*, in
practice all filesystem implementations treat it as a string
of comma-separated mount options.

R=bradfitzgo, bradfitzwork
CC=golang-dev
http://codereview.appspot.com/4247070

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b