code review 4240104: crypto/elliptic: add the N value of each curve.

crypto/elliptic: add the N value of each curve.

[agl1, 2011-03-10 14:59:31]

(missed this from the ecdsa commit, breaking the build.)

[rsc, 2011-03-10 15:00:39]

Lgtm
On Mar 10, 2011 9:59 AM, <agl@golang.org> wrote:
> Reviewers: rsc,
>
> Message:
> (missed this from the ecdsa commit, breaking the build.)
>
> Description:
> crypto/elliptic: add the N value of each curve.
>
> Please review this at http://codereview.appspot.com/4240104/
>
> Affected files:
> M src/pkg/crypto/elliptic/elliptic.go
>
>
> Index: src/pkg/crypto/elliptic/elliptic.go
> ===================================================================
> --- a/src/pkg/crypto/elliptic/elliptic.go
> +++ b/src/pkg/crypto/elliptic/elliptic.go
> @@ -24,6 +24,7 @@
> // See http://www.hyperelliptic.org/EFD/g1p/auto-shortw.html
> type Curve struct {
> P *big.Int // the order of the underlying field
> + N *big.Int // the order of the base point
> B *big.Int // the constant of the curve equation
> Gx, Gy *big.Int // (x,y) of the base point
> BitSize int // the size of the underlying field
> @@ -315,6 +316,7 @@
> // See FIPS 186-3, section D.2.2
> p224 = new(Curve)
> p224.P, _ =
>
new(big.Int).SetString("26959946667150639794667015087019630673557916260026308143510066298881",

> 10)
> + p224.N, _ =
>
new(big.Int).SetString("26959946667150639794667015087019625940457807714424391721682722368061",

> 10)
> p224.B, _ =
>
new(big.Int).SetString("b4050a850c04b3abf54132565044b0b7d7bfd8ba270b39432355ffb4",

> 16)
> p224.Gx, _ =
>
new(big.Int).SetString("b70e0cbd6bb4bf7f321390b94a03c1d356c21122343280d6115c1d21",

> 16)
> p224.Gy, _ =
>
new(big.Int).SetString("bd376388b5f723fb4c22dfe6cd4375a05a07476444d5819985007e34",

> 16)
> @@ -325,6 +327,7 @@
> // See FIPS 186-3, section D.2.3
> p256 = new(Curve)
> p256.P, _ =
>
new(big.Int).SetString("115792089210356248762697446949407573530086143415290314195533631308867097853951",

> 10)
> + p256.N, _ =
>
new(big.Int).SetString("115792089210356248762697446949407573529996955224135760342422259061068512044369",

> 10)
> p256.B, _ =
>
new(big.Int).SetString("5ac635d8aa3a93e7b3ebbd55769886bc651d06b0cc53b0f63bce3c3e27d2604b",

> 16)
> p256.Gx, _ =
>
new(big.Int).SetString("6b17d1f2e12c4247f8bce6e563a440f277037d812deb33a0f4a13945d898c296",

> 16)
> p256.Gy, _ =
>
new(big.Int).SetString("4fe342e2fe1a7f9b8ee7eb4a7c0f9e162bce33576b315ececbb6406837bf51f5",

> 16)
> @@ -335,6 +338,7 @@
> // See FIPS 186-3, section D.2.4
> p384 = new(Curve)
> p384.P, _ =
>
new(big.Int).SetString("39402006196394479212279040100143613805079739270465446667948293404245721771496870329047266088258938001861606973112319",

> 10)
> + p384.N, _ =
>
new(big.Int).SetString("39402006196394479212279040100143613805079739270465446667946905279627659399113263569398956308152294913554433653942643",

> 10)
> p384.B, _ =
>
new(big.Int).SetString("b3312fa7e23ee7e4988e056be3f82d19181d9c6efe8141120314088f5013875ac656398d8a2ed19d2a85c8edd3ec2aef",

> 16)
> p384.Gx, _ =
>
new(big.Int).SetString("aa87ca22be8b05378eb1c71ef320ad746e1d3b628ba79b9859f741e082542a385502f25dbf55296c3a545e3872760ab7",

> 16)
> p384.Gy, _ =
>
new(big.Int).SetString("3617de4a96262c6f5d9e98bf9292dc29f8f41dbd289a147ce9da3113b5f0b8c00a60b1ce1d7e819d7a431d7c90ea0e5f",

> 16)
> @@ -345,6 +349,7 @@
> // See FIPS 186-3, section D.2.5
> p521 = new(Curve)
> p521.P, _ =
>
new(big.Int).SetString("6864797660130609714981900799081393217269435300143305409394463459185543183397656052122559640661454554977296311391480858037121987999716643812574028291115057151",

> 10)
> + p521.N, _ =
>
new(big.Int).SetString("6864797660130609714981900799081393217269435300143305409394463459185543183397655394245057746333217197532963996371363321113864768612440380340372808892707005449",

> 10)
> p521.B, _ =
>
new(big.Int).SetString("051953eb9618e1c9a1f929a21a0b68540eea2da725b99b315f3b8b489918ef109e156193951ec7e937b1652c0bd3bb1bf073573df883d2c34f1ef451fd46b503f00",

> 16)
> p521.Gx, _ =
>
new(big.Int).SetString("c6858e06b70404e9cd9e3ecb662395b4429c648139053fb521f828af606b4d3dbaa14b5e77efe75928fe1dc127a2ffa8de3348b3c1856a429bf97e7e31c2e5bd66",

> 16)
> p521.Gy, _ =
>
new(big.Int).SetString("11839296a789a3bc0045c8a5fb42c7d1bd998f54449579b446817afbd17273e662c97ee72995ef42640c550b9013fad0761353c7086a272c24088be94769fd16650",

> 16)
>
>

[agl1, 2011-03-10 15:04:05]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[agl1, 2011-03-10 15:04:31]

*** Submitted as http://code.google.com/p/go/source/detail?r=9990521e6901 ***

crypto/elliptic: add the N value of each curve.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4240104