code review 4239077: http: add Flusher type; remove Flush from ResponseWriter

http: add Flusher type; remove Flush from ResponseWriter

The Flush functionality wasn't removed, but now you have
to test if your ResponseWriter is also a Flusher:

func ServeHTTP(rw http.ResponseWriter, req *http.Request) {
   if f, ok := rw.(http.Flusher); ok {
       f.Flush()
   }
}

[bradfitz, 2011-03-09 18:10:14]

Hello rsc (cc: gburd, golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[bradfitzgoog, 2011-03-09 18:20:10]

It's telling that this CL is so short and no code in the Go tree had to be
updated.


On Wed, Mar 9, 2011 at 10:10 AM, <bradfitz@golang.org> wrote:

> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: gburd, golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> http: add Flusher type; remove Flush from ResponseWriter
>
> The Flush functionality wasn't removed, but now you have
> to test if your ResponseWriter is also a Flusher:
>
> func ServeHTTP(rw http.ResponseWriter, req *http.Request) {
>   if f, ok := rw.(http.Flusher); ok {
>       f.Flush()
>   }
> }
>
> Please review this at http://codereview.appspot.com/4239077/
>
> Affected files:
>  M src/pkg/http/server.go
>
>
> Index: src/pkg/http/server.go
> ===================================================================
> --- a/src/pkg/http/server.go
> +++ b/src/pkg/http/server.go
> @@ -70,8 +70,14 @@
>        // Thus explicit calls to WriteHeader are mainly used to
>        // send error codes.
>        WriteHeader(int)
> +}
>
> +// The Flusher interface is implemented by ResponseWriters that allow
> +// an HTTP handler to flush buffered data to the client.
> +type Flusher interface {
>        // Flush sends any buffered data to the client.
> +       // If there are proxies between the client and server
> +       // Flush may not get data all the way to the client.
>        Flush()
>  }
>
>
>
>

[rsc, 2011-03-09 18:24:07]

LGTM

i'd move the extra lines on the Flush() method up into the main flusher comment.

// Note that even for ResponseWriters that support Flush,
// if the client is connected through an HTTP proxy,
// the buffered data may not reach the client until the response
// completes.

[bradfitz, 2011-03-09 18:24:55]

*** Submitted as 8392577a953b ***

http: add Flusher type; remove Flush from ResponseWriter

The Flush functionality wasn't removed, but now you have
to test if your ResponseWriter is also a Flusher:

func ServeHTTP(rw http.ResponseWriter, req *http.Request) {
   if f, ok := rw.(http.Flusher); ok {
       f.Flush()
   }
}

R=rsc, bradfitzwork
CC=gburd, golang-dev
http://codereview.appspot.com/4239077