Issue 4239071: code review 4239071: govet: handle '*' in print format strings.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4239071: code review 4239071: govet: handle '*' in print format strings. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by r

Modified:
14 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

govet: handle '*' in print format strings. While we're on govet, fix a couple of mistakes in a test. Fixes issue 1592.

Patch Set 1 #

Patch Set 2 : diff -r df09530bb2ee https://go.googlecode.com/hg/ #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -12 lines)			Patch
	M	src/cmd/govet/govet.go	View	1	3 chunks	+55 lines, -10 lines	0 comments	Download
	M	src/pkg/fmt/scan_test.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 2 months ago (2011-03-08 22:23:45 UTC) #1

rsc

LGTM Maybe move the %% check down after the // Now a verb comment. Might ...

14 years, 2 months ago (2011-03-08 22:35:29 UTC) #2

14 years, 2 months ago (2011-03-08 22:37:03 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=fbb39745c3f7 ***

govet: handle '*' in print format strings.
While we're on govet, fix a couple of mistakes in a test.

Fixes issue 1592.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4239071

Expand All Messages | Collapse All Messages