Issue 4237059: Makes the footnote separator span part of the page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4237059: Makes the footnote separator span part of the page (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by MikeSol

Modified:
13 years, 1 month ago

Reviewers:
Bertrand Bordage, carl.d.sorensen, Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Makes the footnote separator span part of the page

Patch Set 1 #

Total comments: 3

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	ly/paper-defaults-init.ly	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	scm/define-markup-commands.scm	View		2 chunks	+8 lines, -2 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Neil Puttock

LGTM. http://codereview.appspot.com/4237059/diff/1/ly/paper-defaults-init.ly File ly/paper-defaults-init.ly (right): http://codereview.appspot.com/4237059/diff/1/ly/paper-defaults-init.ly#newcode109 ly/paper-defaults-init.ly:109: footnote-separator-markup = \markup { \override #`(span-factor . ,(/ ...

13 years, 2 months ago (2011-03-07 22:23:50 UTC) #2

Bertrand Bordage

13 years, 2 months ago (2011-03-09 17:50:13 UTC) #3

http://codereview.appspot.com/4237059/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):

http://codereview.appspot.com/4237059/diff/1/scm/define-markup-commands.scm#n...
scm/define-markup-commands.scm:159: (markup #:fill-line
I suggest you move this fill-line to ly/paper-defaults-init.ly
As left-aligned footnotes separators are more usual than the centered ones, it
must be easy for users to modify this.

Expand All Messages | Collapse All Messages