code review 4237051: re2: add endpos to RE2::Match, fix bugs

re2: add endpos to RE2::Match, fix bugs

Adding endpos to RE2::Match allows callers to limit the ending
position of matches to points before the end of the text.

Found and fixed a few bugs involving startpos and endpos not
being handled properly.  These would only affect callers using
Match directly.  They cannot affect callers using FullMatch,
PartialMatch, and DoMatch, because those always use startpos == 0.

[rsc, 2011-03-02 20:47:19]

Hello r (cc: re2-dev@googlegroups.com),

I'd like you to review this change to
https://re2.googlecode.com/hg/

[r, 2011-03-02 20:54:42]

LGTM

http://codereview.appspot.com/4237051/diff/5001/re2/testing/tester.h
File re2/testing/tester.h (right):

http://codereview.appspot.com/4237051/diff/5001/re2/testing/tester.h#newcode44
re2/testing/tester.h:44: }
i'll presume this is necessary without further elaboration, although the "Sigh"
could perhaps be replaced by an explanation

[rsc_swtch, 2011-03-02 20:58:13]

// Make normal math on the enum preserve the type.
// By default, C++ doesn't define ++ on enum, and e+1 has type int.

[rsc, 2011-03-02 20:59:51]

*** Submitted as http://code.google.com/p/re2/source/detail?r=d9f8806c004d ***

re2: add endpos to RE2::Match, fix bugs

Adding endpos to RE2::Match allows callers to limit the ending
position of matches to points before the end of the text.

Found and fixed a few bugs involving startpos and endpos not
being handled properly.  These would only affect callers using
Match directly.  They cannot affect callers using FullMatch,
PartialMatch, and DoMatch, because those always use startpos == 0.

R=r, rsc_swtch
CC=re2-dev
http://codereview.appspot.com/4237051