Issue 4237041: Fix 748. Key signatures for modes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4237041: Fix 748. Key signatures for modes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by Keith

Modified:
13 years, 1 month ago

Reviewers:
Graham Percival (old account)

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix 748. Key signatures for modes Compute midi key signatures without crashing, using code from Graham Breed. Provide a keyAlterationOrder for the modes in arabic.ly.

Patch Set 2 : add regression test #

Total comments: 2

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -17 lines)			Patch
A	input/regression/midi-key-signature.ly	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	ly/arabic.ly	View		1 chunk	+35 lines, -15 lines	2 comments	Download
M	scm/midi.scm	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Graham Percival (old account)

LGTM, passes regtests. http://codereview.appspot.com/4237041/diff/2001/ly/arabic.ly File ly/arabic.ly (right): http://codereview.appspot.com/4237041/diff/2001/ly/arabic.ly#newcode36 ly/arabic.ly:36: (0 . ,NATURAL) This might cause ...

13 years, 2 months ago (2011-02-25 05:58:55 UTC) #1

Felipe

http://codereview.appspot.com/4237041/diff/2001/ly/arabic.ly File ly/arabic.ly (right): http://codereview.appspot.com/4237041/diff/2001/ly/arabic.ly#newcode36 ly/arabic.ly:36: (0 . ,NATURAL) On 2011/02/25 05:58:55, Graham Percival wrote: ...

13 years, 2 months ago (2011-02-25 14:06:05 UTC) #2

No complaints, so please push.

Expand All Messages | Collapse All Messages