Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(333)

Issue 4236043: Cleaning Feta flags code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by lemniskata.bernoulliego
Modified:
13 years ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Cleaning Feta flags code This patch makes flags code more uniform and easier to maintain. There is no actual change to the font itself, only to the way it is coded.

Patch Set 1 #

Total comments: 2

Patch Set 2 : indents before "flare" fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -127 lines) Patch
M mf/feta-flags.mf View 1 22 chunks +141 lines, -127 lines 0 comments Download

Messages

Total messages: 7
Janek Warchol
This is a preparation for changes in the flag code that will be made later ...
13 years, 2 months ago (2011-02-25 10:25:32 UTC) #1
Marek
I have created new [PATCH] issue for this: http://code.google.com/p/lilypond/issues/detail?id=1541
13 years, 2 months ago (2011-02-25 11:06:42 UTC) #2
Janek Warchol
2011/2/25 <neziap@googlemail.com>: > I have created new [PATCH] issue for this: > http://code.google.com/p/lilypond/issues/detail?id=1541 Thanks!
13 years, 2 months ago (2011-02-25 13:11:02 UTC) #3
hanwenn
LGTM please fix all indents http://codereview.appspot.com/4236043/diff/1/mf/feta-flags.mf File mf/feta-flags.mf (right): http://codereview.appspot.com/4236043/diff/1/mf/feta-flags.mf#newcode138 mf/feta-flags.mf:138: save flagspace, total_depth, flag_count; ...
13 years, 2 months ago (2011-02-25 14:58:25 UTC) #4
Janek Warchol
Indents fixed. Sorry it took so long - i had limited access to my lilydev-enabled ...
13 years, 1 month ago (2011-03-02 21:29:06 UTC) #5
Graham Percival (old account)
LGTM, passes regtests. I'm not familiar with how we indent our mf files, so I ...
13 years, 1 month ago (2011-03-03 09:51:28 UTC) #6
Graham Percival (old account)
13 years, 1 month ago (2011-03-08 13:04:48 UTC) #7
Hearing no objections to the contrary, let's move forward.  Janek, could you
send me a patch for pushing?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b