Issue 4235064: Use XkbKeysymToModifiers to check AltGr modifier.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4235064: Use XkbKeysymToModifiers to check AltGr modifier. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by Daiki Ueno

Modified:
13 years, 1 month ago

Reviewers:
shawn.p.huang

Base URL:
git@github.com:ibus/ibus-m17n.git@master

Visibility:
Public.

Description

Use XkbKeysymToModifiers to check AltGr modifier. Currently, ibus-m17n assumes that AltGr is mapped to MOD5. However, it may be mapped to different non-virtual modifiers. This patch uses XkbKeysymToModifiers to check which modifier AltGr is mapped to. BUG=none TEST=manual

Patch Set 1 #

Patch Set 2 : simplified #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -22 lines)			Patch
	configure.ac	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	src/Makefile.am	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/engine.c	View	1	5 chunks	+24 lines, -22 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

On 2011/03/09 08:09:51, Daiki Ueno wrote: Is it necessary? It is not good to let ...

13 years, 2 months ago (2011-03-09 14:05:58 UTC) #2

Daiki Ueno

13 years, 1 month ago (2011-03-18 07:14:52 UTC) #3

On 2011/03/09 14:05:58, Peng wrote:
> On 2011/03/09 08:09:51, Daiki Ueno wrote:
> Is it necessary? It is not good to let engine depend on X, and it also make
> increase the start up time.

Sorry for late response.  After discussion with the people really wanting AltGr,
it turned out that more comprehensive support of AltGr in ibus side seems
necessary.  I'll close this and file a bug report with the full story later. 
Anyway thanks for taking a look of this.

Expand All Messages | Collapse All Messages