code review 4235052: fmt: trivial cleanup

fmt: trivial cleanup

[rh, 2011-03-06 01:04:34]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-03-06 01:33:47]

Robert,

LGTM but see the instructions at the top of the CONTRIBUTORS file before we
can submit the patch.

- Brad

On Sat, Mar 5, 2011 at 5:04 PM, <robert.hencke@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> fmt: trivial cleanup
>
> Please review this at http://codereview.appspot.com/4235052/
>
> Affected files:
>  M src/pkg/fmt/format.go
>  M src/pkg/fmt/scan_test.go
>
>
> Index: src/pkg/fmt/format.go
> ===================================================================
> --- a/src/pkg/fmt/format.go
> +++ b/src/pkg/fmt/format.go
> @@ -107,7 +107,7 @@
>  }
>
>  // Append b to f.buf, padded on left (w > 0) or right (w < 0 or f.minus)
> -// clear flags aftewards.
> +// clear flags afterwards.
>  func (f *fmt) pad(b []byte) {
>        var padding []byte
>        var left, right int
> @@ -124,7 +124,7 @@
>  }
>
>  // append s to buf, padded on left (w > 0) or right (w < 0 or f.minus).
> -// clear flags aftewards.
> +// clear flags afterwards.
>  func (f *fmt) padString(s string) {
>        var padding []byte
>        var left, right int
> Index: src/pkg/fmt/scan_test.go
> ===================================================================
> --- a/src/pkg/fmt/scan_test.go
> +++ b/src/pkg/fmt/scan_test.go
> @@ -476,22 +476,12 @@
>        }
>  }
>
> -
>  func TestInf(t *testing.T) {
>        for _, s := range []string{"inf", "+inf", "-inf", "INF", "-INF",
> "+INF", "Inf", "-Inf", "+Inf"} {
>                verifyInf(s, t)
>        }
>  }
>
> -// TODO: there's no conversion from []T to ...T, but we can fake it.
>  These
> -// functions do the faking.  We index the table by the length of the param
> list.
> -var fscanf = []func(io.Reader, string, []interface{}) (int, os.Error){
> -       0: func(r io.Reader, f string, i []interface{}) (int, os.Error) {
> return Fscanf(r, f) },
> -       1: func(r io.Reader, f string, i []interface{}) (int, os.Error) {
> return Fscanf(r, f, i[0]) },
> -       2: func(r io.Reader, f string, i []interface{}) (int, os.Error) {
> return Fscanf(r, f, i[0], i[1]) },
> -       3: func(r io.Reader, f string, i []interface{}) (int, os.Error) {
> return Fscanf(r, f, i[0], i[1], i[2]) },
> -}
> -
>  func testScanfMulti(name string, t *testing.T) {
>        sliceType := reflect.Typeof(make([]interface{},
> 1)).(*reflect.SliceType)
>        for _, test := range multiTests {
> @@ -501,7 +491,7 @@
>                } else {
>                        r = newReader(test.text)
>                }
> -               n, err := fscanf[len(test.in)](r, test.format, test.in)
> +               n, err := Fscanf(r, test.format, test.in...)
>                if err != nil {
>                        if test.err == "" {
>                                t.Errorf("got error scanning (%q, %q): %q",
> test.format, test.text, err)
>
>
>

[bradfitz, 2011-03-06 01:55:57]

*** Submitted as http://code.google.com/p/go/source/detail?r=510d0d55eeb5 ***

fmt: trivial cleanup

R=golang-dev, bradfitzgo
CC=golang-dev
http://codereview.appspot.com/4235052

Committer: Brad Fitzpatrick <bradfitz@golang.org>