Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1707)

Issue 42330044: splitting file movement and whitespace-only changes into separate commits

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by benko.pal
Modified:
10 years, 4 months ago
Reviewers:
wl, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

splitting file movement and whitespace-only changes into separate commits the commits now read (in reverse chronological order): unify formatting and indentation ----------------------------------------------------->8 include subfonts unconditionally ----------------------------------------------------->8 remove spurious else ----------------------------------------------------->8 make comments more uniform ----------------------------------------------------->8 factor out common inclusions and initializations ----------------------------------------------------->8 factor out autometric_parameter declarations ----------------------------------------------------->8 move brace-drawing procedure to separate file (and rename files) ----------------------------------------------------->8 rename feta-alphabet to feta-alphabet-generic to conform to the convention ----------------------------------------------------->8 rename feta-generic to feta-other-generic; similarly parmesan-generic these files are not for the whole font, but just some glyphs that aren't in their own subfonts ----------------------------------------------------->8 remove feta-test-generic.mf and other testing files they were just polluting the code ----------------------------------------------------->8 font: clean up staffline-display in testing mode Previous testing code was a mix of hideous copy&paste with non-obvious passing glyph outlines around, which attempted to produce additional glyphs in testing mode, so that there would be both on-staffline and on-staffspace variations. That code was completely unreadable and unmaintainable. Instead i've introduced a global variable that determines how the stafflines will be printed relative to the glyphs. To see alternative configuration, just change that value. ----------------------------------------------------->8 font: rename draw_staff to draw_staff_if_debugging Previous name was confusing: the stafflines are actually not drawn unless 'test' is set to non-zero value. ----------------------------------------------------->8 feta accidentals: split into several files ----------------------------------------------------->8 omit filename extension as in the rest of the file

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1473 lines, -2485 lines) Patch
A mf/common-modules-and-initialization.mf View 1 chunk +7 lines, -0 lines 0 comments Download
A mf/debugging-settings.mf View 1 chunk +14 lines, -0 lines 0 comments Download
A mf/declare-autometric-parameters.mf View 1 chunk +9 lines, -0 lines 0 comments Download
M mf/feta-accidentals.mf View 2 chunks +5 lines, -1277 lines 0 comments Download
D mf/feta-alphabet.mf View 1 chunk +0 lines, -19 lines 0 comments Download
A mf/feta-alphabet-generic.mf View 1 chunk +19 lines, -0 lines 0 comments Download
M mf/feta-alphabet11.mf View 1 chunk +2 lines, -2 lines 0 comments Download
M mf/feta-alphabet13.mf View 1 chunk +2 lines, -2 lines 0 comments Download
M mf/feta-alphabet14.mf View 1 chunk +2 lines, -2 lines 0 comments Download
M mf/feta-alphabet16.mf View 1 chunk +2 lines, -2 lines 0 comments Download
M mf/feta-alphabet18.mf View 1 chunk +2 lines, -2 lines 0 comments Download
M mf/feta-alphabet20.mf View 1 chunk +2 lines, -3 lines 0 comments Download
M mf/feta-alphabet23.mf View 1 chunk +2 lines, -3 lines 0 comments Download
M mf/feta-alphabet26.mf View 1 chunk +2 lines, -2 lines 0 comments Download
A mf/feta-arrow.mf View 1 chunk +82 lines, -0 lines 0 comments Download
M mf/feta-braces.mf View 2 chunks +0 lines, -40 lines 0 comments Download
M mf/feta-braces-a.mf View 1 chunk +1 line, -18 lines 0 comments Download
M mf/feta-braces-b.mf View 1 chunk +1 line, -18 lines 0 comments Download
M mf/feta-braces-c.mf View 1 chunk +1 line, -18 lines 0 comments Download
M mf/feta-braces-d.mf View 1 chunk +1 line, -18 lines 0 comments Download
M mf/feta-braces-e.mf View 1 chunk +1 line, -18 lines 0 comments Download
M mf/feta-braces-f.mf View 1 chunk +1 line, -18 lines 0 comments Download
M mf/feta-braces-g.mf View 1 chunk +1 line, -18 lines 0 comments Download
A mf/feta-braces-generic.mf View 1 chunk +47 lines, -0 lines 0 comments Download
M mf/feta-braces-h.mf View 1 chunk +1 line, -18 lines 0 comments Download
M mf/feta-braces-i.mf View 1 chunk +1 line, -18 lines 0 comments Download
M mf/feta-clefs.mf View 5 chunks +5 lines, -5 lines 0 comments Download
M mf/feta-flags-generic.mf View 2 chunks +3 lines, -30 lines 0 comments Download
M mf/feta-flags11.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/feta-flags13.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/feta-flags14.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/feta-flags16.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/feta-flags18.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/feta-flags20.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/feta-flags23.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/feta-flags26.mf View 1 chunk +1 line, -9 lines 0 comments Download
A mf/feta-flats.mf View 1 chunk +535 lines, -0 lines 0 comments Download
D mf/feta-generic.mf View 1 chunk +0 lines, -60 lines 0 comments Download
M mf/feta-macros.mf View 2 chunks +4 lines, -3 lines 0 comments Download
A mf/feta-naturals.mf View 1 chunk +150 lines, -0 lines 0 comments Download
M mf/feta-noteheads.mf View 15 chunks +24 lines, -208 lines 0 comments Download
M mf/feta-noteheads-generic.mf View 2 chunks +3 lines, -30 lines 0 comments Download
M mf/feta-noteheads11.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/feta-noteheads13.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/feta-noteheads14.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/feta-noteheads16.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/feta-noteheads18.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/feta-noteheads20.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/feta-noteheads23.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/feta-noteheads26.mf View 1 chunk +1 line, -9 lines 0 comments Download
A mf/feta-other-generic.mf View 1 chunk +29 lines, -0 lines 0 comments Download
A mf/feta-parenthesis.mf View 1 chunk +44 lines, -0 lines 0 comments Download
M mf/feta-rests.mf View 14 chunks +11 lines, -17 lines 0 comments Download
M mf/feta-scripts.mf View 2 chunks +1 line, -2 lines 0 comments Download
A mf/feta-sharps.mf View 1 chunk +353 lines, -0 lines 0 comments Download
D mf/feta-test-generic.mf View 1 chunk +0 lines, -17 lines 0 comments Download
D mf/feta-test11.mf View 1 chunk +0 lines, -15 lines 0 comments Download
D mf/feta-test13.mf View 1 chunk +0 lines, -16 lines 0 comments Download
D mf/feta-test16.mf View 1 chunk +0 lines, -16 lines 0 comments Download
D mf/feta-test20.mf View 1 chunk +0 lines, -16 lines 0 comments Download
D mf/feta-test23.mf View 1 chunk +0 lines, -16 lines 0 comments Download
D mf/feta-test26.mf View 1 chunk +0 lines, -15 lines 0 comments Download
M mf/feta-timesignatures.mf View 1 chunk +1 line, -1 line 0 comments Download
M mf/feta11.mf View 1 chunk +2 lines, -9 lines 0 comments Download
M mf/feta13.mf View 1 chunk +2 lines, -9 lines 0 comments Download
M mf/feta14.mf View 1 chunk +2 lines, -10 lines 0 comments Download
M mf/feta16.mf View 1 chunk +2 lines, -9 lines 0 comments Download
M mf/feta18.mf View 1 chunk +2 lines, -10 lines 0 comments Download
M mf/feta20.mf View 1 chunk +2 lines, -9 lines 0 comments Download
M mf/feta23.mf View 1 chunk +2 lines, -11 lines 0 comments Download
M mf/feta26.mf View 1 chunk +2 lines, -11 lines 0 comments Download
M mf/parmesan-clefs.mf View 19 chunks +19 lines, -57 lines 0 comments Download
D mf/parmesan-generic.mf View 1 chunk +0 lines, -50 lines 0 comments Download
M mf/parmesan-noteheads-generic.mf View 2 chunks +1 line, -21 lines 0 comments Download
M mf/parmesan-noteheads11.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/parmesan-noteheads13.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/parmesan-noteheads14.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/parmesan-noteheads16.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/parmesan-noteheads18.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/parmesan-noteheads20.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/parmesan-noteheads23.mf View 1 chunk +1 line, -9 lines 0 comments Download
M mf/parmesan-noteheads26.mf View 1 chunk +1 line, -9 lines 0 comments Download
A mf/parmesan-other-generic.mf View 1 chunk +26 lines, -0 lines 0 comments Download
M mf/parmesan11.mf View 1 chunk +2 lines, -9 lines 0 comments Download
M mf/parmesan13.mf View 1 chunk +2 lines, -10 lines 0 comments Download
M mf/parmesan14.mf View 1 chunk +2 lines, -11 lines 0 comments Download
M mf/parmesan16.mf View 1 chunk +2 lines, -10 lines 0 comments Download
M mf/parmesan18.mf View 1 chunk +2 lines, -10 lines 0 comments Download
M mf/parmesan20.mf View 1 chunk +2 lines, -10 lines 0 comments Download
M mf/parmesan23.mf View 1 chunk +2 lines, -10 lines 0 comments Download
M mf/parmesan26.mf View 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 5
benko.pal
continuation of http://codereview.appspot.com/38530043 belonging to http://code.google.com/p/lilypond/issues/detail?id=3705 if requested, I can either update dev/janek/metafont-cleanup or push ...
10 years, 4 months ago (2013-12-14 16:31:23 UTC) #1
lemzwerg
> if requested, I can either update dev/janek/metafont-cleanup > or push as a new branch. ...
10 years, 4 months ago (2013-12-15 00:04:51 UTC) #2
lemzwerg
10 years, 4 months ago (2013-12-15 00:04:58 UTC) #3
benko.pal
>> if requested, I can either update dev/janek/metafont-cleanup >> or push as a new branch. ...
10 years, 4 months ago (2013-12-15 18:05:23 UTC) #4
wl_gnu.org
10 years, 4 months ago (2013-12-15 21:36:42 UTC) #5
> pushed as
> dev/benko/metafont-cleanup

LGTM, thanks!


    Werner
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b