Metafont code cleanup

Metafont code cleanup

Commits (in reverse chronological order):

font: abstract stuff away, unify, format

* move common elements to separate input files,
* move brace-drawing procedure to separate file,
* rename feta-alphabet to feta-alphabet-generic
  to conform to the convention,
* rename feta-generic to feta-other-generic
  (because this file is not for the whole font,
  but just some glyphs that aren't in their own
  subfonts); similarly parmesan-generic,
* remove feta-test-generic.mf and other testing
  files that were just polluting the code,
* put testing code in one place,
* remove spurious filename comments,
* unify formatting and indentation.


font: clean up staffline-display in testing mode

Previous testing code was a mix of hideous copy&paste with
non-obvious passing glyph outlines around, which attempted
to produce additional glyphs in testing mode, so that there
would be both on-staffline and on-staffspace variations.

That code was completely unreadable and unmaintainable.

Instead i've introduced a global variable that determines
how the stafflines will be printed relative to the glyphs.
To see alternative configuration, just change that value.


font: rename draw_staff to draw_staff_if_debugging

Previous name was confusing: the stafflines are actually
not drawn unless 'test' is set to non-zero value.


feta accidentals: split into several files

[janek, 2013-12-06 19:13:56]

Hi,

I decided that it's a good time to clean the Metafont code a bit.  Apart from
what i've done, it'd be nice to do one more thing: move files to subfolders.

We have several "master files" (feta-flags-generic, feta-alphabet-generic,
feta-braces-generic, feta-noteheads-generic, feta-other-generic,
parmesan-noteheads-generic and parmesan-other-generic).  All other files are
just included into these.  I think that it would be good to have a subdir for
each of these fonts - it would make things *much* clearer.

However, this requires changes in the makefile and it seems that i cannot handle
them (i have no experience with make whatsoever, and no time to learn it now
:/).  Maybe someone'd like to help?  I suppose that for someone familiar with
make it'd be 20-30 minutes of work.

You can see the changes separated into commits on dev/janek/metafont-cleanup

thanks!
Janek

[hanwenn, 2013-12-09 09:30:32]

i have not looked at the code, but small nit: I think you could leave the new
subdirectory for another time. 5 files (and only accidentals) does not fix
anything, and rather adds to the confusion.

[hanwenn, 2013-12-09 09:31:57]

also, for reviewing, you should do the file reorganization and the code
reorganization in different changes.

[dak, 2013-12-09 10:03:43]

On 2013/12/09 09:31:57, hanwenn wrote:
> also, for reviewing, you should do the file reorganization and the code
> reorganization in different changes.

It's also a good idea to move files and change files in different commits since
git gets worse at tracking moves/renames the more changes happen in a single
commit.  While you can give git special command line options to make it more
thorough, it's a pain to do this for the various tools and workflows somehow
trying to reconstruct history.

[janek, 2013-12-09 17:15:55]

2013/12/9  <hanwenn@gmail.com>:
> i have not looked at the code, but small nit: I think you could leave
> the new subdirectory for another time. 5 files (and only accidentals)
> does not fix anything, and rather adds to the confusion.

Indeed.  I'll remove the subdir, but keep the split.


2013/12/9  <hanwenn@gmail.com>:
> also, for reviewing, you should do the file reorganization and the code
> reorganization in different changes.

2013/12/9  <dak@gnu.org>:
> It's also a good idea to move files and change files in different
> commits since git gets worse at tracking moves/renames the more changes
> happen in a single commit.  While you can give git special command line
> options to make it more thorough, it's a pain to do this for the various
> tools and workflows somehow trying to reconstruct history.

You're right, i apologize.  Had i known right from the start what
exactly i was going to do, i'd try to keep this separation
consistently.  But since i had no idea what the end result was going
to be (due to the code being messy), i didn't organize it well and it
got mixed.

However, if you don't mind, i'd prefer to leave it as is - i have
_already_ spent about 4 hours cleaning up and rebasing commits to make
them somewhat ordered for review, and i'm quite tired.

Anyway, thanks for the review!
Janek

[benko.pal, 2013-12-10 13:41:23]

> However, if you don't mind, i'd prefer to leave it as is - i have
> _already_ spent about 4 hours cleaning up and rebasing commits to make
> them somewhat ordered for review, and i'm quite tired.

I do mind.  this is not the sort of thing that can be done in a
follow up patch.  If you don't want to do that, I can do the
only-move-files-in-the-first-commit part, but I can't promise
I'll finish before the weekend.

p

[janek, 2013-12-11 11:45:20]

2013/12/10  <benko.pal@gmail.com>:
>> However, if you don't mind, i'd prefer to leave it as is - i have
>> _already_ spent about 4 hours cleaning up and rebasing commits to make
>> them somewhat ordered for review, and i'm quite tired.
>
>
> I do mind.  this is not the sort of thing that can be done in a
> follow up patch.  If you don't want to do that, I can do the
> only-move-files-in-the-first-commit part, but I can't promise
> I'll finish before the weekend.

http://lists.gnu.org/archive/html/lilypond-devel/2013-12/msg00145.html
- sorry :(
so if you could do this it would be great!

best,
Janek

[benko.pal, 2013-12-11 13:29:14]

hi Janek,

2013/12/11 Janek Warchoł <janek.lilypond@gmail.com>:
> 2013/12/10  <benko.pal@gmail.com>:
>>> However, if you don't mind, i'd prefer to leave it as is - i have
>>> _already_ spent about 4 hours cleaning up and rebasing commits to make
>>> them somewhat ordered for review, and i'm quite tired.
>>
>>
>> I do mind.  this is not the sort of thing that can be done in a
>> follow up patch.  If you don't want to do that, I can do the
>> only-move-files-in-the-first-commit part, but I can't promise
>> I'll finish before the weekend.
>
> http://lists.gnu.org/archive/html/lilypond-devel/2013-12/msg00145.html
> - sorry :(
> so if you could do this it would be great!

ok, I'll do it.  I hope you'll get better soon.
(the upside of this is that I don't have to hurry ;))

p

[benko.pal, 2013-12-14 17:01:41]

> >>> However, if you don't mind, i'd prefer to leave it as is - i have
> >>> _already_ spent about 4 hours cleaning up and rebasing commits to make
> >>> them somewhat ordered for review, and i'm quite tired.
> >>
> >>
> >> I do mind.  this is not the sort of thing that can be done in a
> >> follow up patch.  If you don't want to do that, I can do the
> >> only-move-files-in-the-first-commit part, but I can't promise
> >> I'll finish before the weekend.

continued in
https://codereview.appspot.com/42330044/