Issue 4208043: Change svnmailer hooks to ignore branches/google/* (Closed)
|
Created:
13 years, 2 months ago by Diego Novillo Modified:
13 years, 1 month ago Reviewers:
richard.guenther, hjl.tools, iant2, joseph, pinskia CC:
gcc-patches_gcc.gnu.org Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/hooks/ Visibility:
Public. |
Patch Set 1 #Patch Set 2 : Exclude google/* from bugzilla mail #MessagesTotal messages: 12
When we merge into the google/* branches, we would like to preserve the original log messages to facilitate patch archaelogy. However, this causes problems with bugzilla spam. This patch prevents this by removing branches/google/* from the announce message sent by the svn server. OK to commit to hooks? Thanks. Diego. Index: svnmailer.conf =================================================================== --- svnmailer.conf (revision 170444) +++ svnmailer.conf (working copy) @@ -87,3 +87,4 @@ to_addr = java-cvs@gcc.gnu.org to_addr = gcc-cvs@gcc.gnu.org #to_addr = dberlin@dberlin.org bugzilla_to_addr = gcc-bugzilla@gcc.gnu.org +exclude_paths = .*/branches/google/.* -- This patch is available for review at http://codereview.appspot.com/4208043
Sign in to reply to this message.
On Wed, Feb 23, 2011 at 2:12 PM, Diego Novillo <dnovillo@google.com> wrote: > > When we merge into the google/* branches, we would like to preserve > the original log messages to facilitate patch archaelogy. However, this > causes problems with bugzilla spam. > > This patch prevents this by removing branches/google/* from the announce > message sent by the svn server. > > OK to commit to hooks? I think you should just use git and move away from using subversion if you want to patch archaelogy. Currently you are adding more than just spam, you are also adding lots of revisions which really are not needed. There are better ways of doing a merge, like creating a new branch and applying your patches one at a time. This will create a better patch archaelogy than the way you are doing it. -- Pinski
Sign in to reply to this message.
On Wed, Feb 23, 2011 at 2:44 PM, Andrew Pinski <pinskia@gmail.com> wrote: > On Wed, Feb 23, 2011 at 2:12 PM, Diego Novillo <dnovillo@google.com> wrote: >> >> When we merge into the google/* branches, we would like to preserve >> the original log messages to facilitate patch archaelogy. However, this >> causes problems with bugzilla spam. >> >> This patch prevents this by removing branches/google/* from the announce >> message sent by the svn server. >> >> OK to commit to hooks? > > I think you should just use git and move away from using subversion if > you want to patch archaelogy. Currently you are adding more than just > spam, you are also adding lots of revisions which really are not > needed. There are better ways of doing a merge, like creating a new > branch and applying your patches one at a time. This will create a > better patch archaelogy than the way you are doing it. > That is what I have been doing with x32 work. -- H.J.
Sign in to reply to this message.
On Wed, 23 Feb 2011, Diego Novillo wrote: > When we merge into the google/* branches, we would like to preserve > the original log messages to facilitate patch archaelogy. However, this > causes problems with bugzilla spam. As previously discussed, we want all commits to all branches to go to gcc-cvs, even if it *might* be desirable for some not to result in Bugzilla messages. So anything that suppresses gcc-cvs mails for some branches is inappropriate. -- Joseph S. Myers joseph@codesourcery.com
Sign in to reply to this message.
On Thu, Feb 24, 2011 at 1:33 AM, Joseph S. Myers <joseph@codesourcery.com> wrote: > On Wed, 23 Feb 2011, Diego Novillo wrote: > >> When we merge into the google/* branches, we would like to preserve >> the original log messages to facilitate patch archaelogy. However, this >> causes problems with bugzilla spam. > > As previously discussed, we want all commits to all branches to go to > gcc-cvs, even if it *might* be desirable for some not to result in > Bugzilla messages. So anything that suppresses gcc-cvs mails for some > branches is inappropriate. OTOH we don't necessarily want bugzilla to pick up an non-FSF branch commits (yeah, that implies bugzilla shouldn't normally be used for bugs on random branches). Richard.
Sign in to reply to this message.
On Thu, Feb 24, 2011 at 05:06, Richard Guenther <richard.guenther@gmail.com> wrote: > On Thu, Feb 24, 2011 at 1:33 AM, Joseph S. Myers > <joseph@codesourcery.com> wrote: >> >> As previously discussed, we want all commits to all branches to go to >> gcc-cvs, even if it *might* be desirable for some not to result in >> Bugzilla messages. So anything that suppresses gcc-cvs mails for some >> branches is inappropriate. > > OTOH we don't necessarily want bugzilla to pick up an non-FSF branch > commits (yeah, that implies bugzilla shouldn't normally be used for > bugs on random branches). Yeah. Does anyone know how svnmailer works? Any way to tell it not to trigger bugzilla mail for some branches? I'm fine with gcc-cvs mail, but I really would like to avoid bugzilla mail. Thanks. Diego.
Sign in to reply to this message.
Diego Novillo <dnovillo@google.com> writes: > Yeah. Does anyone know how svnmailer works? Any way to tell it not > to trigger bugzilla mail for some branches? I'm fine with gcc-cvs > mail, but I really would like to avoid bugzilla mail. svnmailer is controlled by //gcc.gnu.org/svn/gcc/hooks/svnmailer.conf. You can set for_paths and exclude_paths in the [gccdefault] section to control whether bugzilla_to_addr is set. If bugzilla_to_addr is not set for some paths, then commits to those paths will not be sent to bugzilla. Docs can be found at http://opensource.perlig.de/svnmailer/ . We are currently running version 1.1.0 on gcc.gnu.org. Ian
Sign in to reply to this message.
On Thu, Feb 24, 2011 at 08:48, Ian Lance Taylor <iant@google.com> wrote: > Diego Novillo <dnovillo@google.com> writes: > >> Yeah. Does anyone know how svnmailer works? Any way to tell it not >> to trigger bugzilla mail for some branches? I'm fine with gcc-cvs >> mail, but I really would like to avoid bugzilla mail. > > svnmailer is controlled by //gcc.gnu.org/svn/gcc/hooks/svnmailer.conf. > You can set for_paths and exclude_paths in the [gccdefault] section to > control whether bugzilla_to_addr is set. If bugzilla_to_addr is not set > for some paths, then commits to those paths will not be sent to > bugzilla. Docs can be found at http://opensource.perlig.de/svnmailer/ . > We are currently running version 1.1.0 on gcc.gnu.org. That's what I thought my patch did. Apparently, it doesn't. I'm not quite sure how to separate the [gccdefault] section. Can you look at my patch and see if I missed anything obvious?
Sign in to reply to this message.
This version only prevents bugzilla email when committing to google/* branches. Index: svnmailer.conf =================================================================== --- svnmailer.conf (revision 170444) +++ svnmailer.conf (working copy) @@ -86,4 +86,7 @@ to_addr = java-cvs@gcc.gnu.org [gccdefault] to_addr = gcc-cvs@gcc.gnu.org #to_addr = dberlin@dberlin.org + +[gccbugzilla] bugzilla_to_addr = gcc-bugzilla@gcc.gnu.org +exclude_paths = .*/branches/google/.* -- This patch is available for review at http://codereview.appspot.com/4208043
Sign in to reply to this message.
dnovillo@google.com (Diego Novillo) writes: > This version only prevents bugzilla email when committing to google/* > branches. > > Index: svnmailer.conf > =================================================================== > --- svnmailer.conf (revision 170444) > +++ svnmailer.conf (working copy) > @@ -86,4 +86,7 @@ to_addr = java-cvs@gcc.gnu.org > [gccdefault] > to_addr = gcc-cvs@gcc.gnu.org > #to_addr = dberlin@dberlin.org > + > +[gccbugzilla] > bugzilla_to_addr = gcc-bugzilla@gcc.gnu.org > +exclude_paths = .*/branches/google/.* This looks reasonable to me. I don't know if there is a way to test it before committing it. Ian
Sign in to reply to this message.
On Thu, Feb 24, 2011 at 09:44, Ian Lance Taylor <iant@google.com> wrote: >> This version only prevents bugzilla email when committing to google/* >> branches. >> >> Index: svnmailer.conf >> =================================================================== >> --- svnmailer.conf (revision 170444) >> +++ svnmailer.conf (working copy) >> @@ -86,4 +86,7 @@ to_addr = java-cvs@gcc.gnu.org >> [gccdefault] >> to_addr = gcc-cvs@gcc.gnu.org >> #to_addr = dberlin@dberlin.org >> + >> +[gccbugzilla] >> bugzilla_to_addr = gcc-bugzilla@gcc.gnu.org >> +exclude_paths = .*/branches/google/.* > > This looks reasonable to me. I don't know if there is a way to test it > before committing it. I can make a single commit mentioning an existing PR and make sure it doesn't generate traffic. Joseph, Richard, does this look OK to you? Diego.
Sign in to reply to this message.
On 2011/02/24 14:48:47, Diego Novillo wrote: > On Thu, Feb 24, 2011 at 09:44, Ian Lance Taylor <mailto:iant@google.com> wrote: > >> This version only prevents bugzilla email when committing to google/* > >> branches. > >> > >> Index: svnmailer.conf > >> =================================================================== > >> --- svnmailer.conf (revision 170444) > >> +++ svnmailer.conf (working copy) > >> @@ -86,4 +86,7 @@ to_addr = mailto:java-cvs@gcc.gnu.org > >> [gccdefault] > >> to_addr = mailto:gcc-cvs@gcc.gnu.org > >> #to_addr = mailto:dberlin@dberlin.org > >> + > >> +[gccbugzilla] > >> bugzilla_to_addr = mailto:gcc-bugzilla@gcc.gnu.org > >> +exclude_paths = .*/branches/google/.* > > > > This looks reasonable to me. I don't know if there is a way to test it > > before committing it. > > I can make a single commit mentioning an existing PR and make sure it > doesn't generate traffic. > > Joseph, Richard, does this look OK to you? Ping. Any objections to this change? It should only stop the google/* branches from generating bugzilla mail. Thanks. Diego.
Sign in to reply to this message.
|
