Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10197)

Issue 41990043: Issue 3720: Built-in templates for SATB vocal scores (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by Trevor Daniels
Modified:
10 years, 3 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3720: Built-in templates for SATB vocal scores Many more templates like this could be provided: this is just a start to see if this approach is worth pursuing further. As this is exploratory, only minimal changes have been made to the documentation - just enough to preserve consistency.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Respond to comments #

Patch Set 3 : Respond to further comments #

Patch Set 4 : Devon Schudy's template and corresponding documentation #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -1 line) Patch
M Documentation/learning/fundamental.itely View 1 2 3 1 chunk +9 lines, -1 line 0 comments Download
M Documentation/learning/templates.itely View 1 2 3 3 chunks +177 lines, -0 lines 0 comments Download
M Documentation/notation/vocal.itely View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A ly/satb.ly View 1 2 3 1 chunk +224 lines, -0 lines 7 comments Download

Messages

Total messages: 25
Jean-Charles
LGTM, except one typo. https://codereview.appspot.com/41990043/diff/1/Documentation/learning/templates.itely File Documentation/learning/templates.itely (right): https://codereview.appspot.com/41990043/diff/1/Documentation/learning/templates.itely#newcode53 Documentation/learning/templates.itely:53: Any of the staves my ...
10 years, 4 months ago (2013-12-14 16:15:14 UTC) #1
Trevor Daniels
On 2013/12/14 16:15:14, Jean-Charles wrote: > LGTM, except one typo. > > https://codereview.appspot.com/41990043/diff/1/Documentation/learning/templates.itely > File ...
10 years, 4 months ago (2013-12-14 18:37:11 UTC) #2
Trevor Daniels
Respond to comments
10 years, 4 months ago (2013-12-14 18:54:38 UTC) #3
Devon Schudy
This interface is unlike any other in Lilypond, in ways that make it less flexible ...
10 years, 4 months ago (2013-12-14 22:32:06 UTC) #4
Keith
On 2013/12/14 22:32:06, Devon Schudy wrote: > This interface is unlike any other in Lilypond, ...
10 years, 4 months ago (2013-12-14 23:17:55 UTC) #5
Trevor Daniels
On 2013/12/14 22:32:06, Devon Schudy wrote: > This interface is unlike any other in Lilypond, ...
10 years, 4 months ago (2013-12-15 09:46:58 UTC) #6
Trevor Daniels
On 2013/12/14 23:17:55, Keith wrote: > On 2013/12/14 22:32:06, Devon Schudy wrote: > > This ...
10 years, 4 months ago (2013-12-15 09:51:30 UTC) #7
Carl P.
On Sun, Dec 15, 2013 at 4:51 AM, <tdanielsmusic@googlemail.com> wrote: > > On 2013/12/14 23:17:55, ...
10 years, 4 months ago (2013-12-15 17:41:17 UTC) #8
Trevor Daniels
On 2013/12/15 17:41:17, Carl P. wrote: > First question I anticipate from users on this, ...
10 years, 4 months ago (2013-12-15 19:40:50 UTC) #9
Trevor Daniels
Respond to further comments
10 years, 4 months ago (2013-12-15 19:53:15 UTC) #10
Carl P.
On Sun, Dec 15, 2013 at 2:40 PM, <tdanielsmusic@googlemail.com> wrote: > Good point. The SA-TB ...
10 years, 4 months ago (2013-12-15 20:00:24 UTC) #11
Devon Schudy
Keith wrote: > This was intended not as an interface to a built-in bulletproof engine, ...
10 years, 4 months ago (2013-12-15 20:06:56 UTC) #12
Trevor Daniels
On 2013/12/15 20:00:24, Carl P. wrote: > I don't know that this is the route ...
10 years, 4 months ago (2013-12-15 22:45:05 UTC) #13
Trevor Daniels
On 2013/12/15 20:06:56, Devon Schudy wrote: > I'd rather support the same thing through music ...
10 years, 4 months ago (2013-12-15 23:01:05 UTC) #14
Devon Schudy
Trevor Daniels wrote: > The point of this patch is to make LilyPond more approachable ...
10 years, 4 months ago (2013-12-17 21:31:19 UTC) #15
janek
Got a free moment.. 2013/12/15 Carl Peterson <carlopeterson@gmail.com>: > I think I share in what ...
10 years, 4 months ago (2013-12-18 14:10:23 UTC) #16
Trevor Daniels
Devon Schudy's template and corresponding documentation
10 years, 4 months ago (2013-12-26 23:29:21 UTC) #17
Trevor Daniels
Pushed to staging Closing ...
10 years, 4 months ago (2013-12-31 09:50:04 UTC) #18
dak
https://codereview.appspot.com/41990043/diff/60001/ly/satb.ly File ly/satb.ly (right): https://codereview.appspot.com/41990043/diff/60001/ly/satb.ly#newcode1 ly/satb.ly:1: %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Missing \version number is causing an error when ...
10 years, 3 months ago (2014-01-05 01:42:55 UTC) #19
Trevor Daniels
On 2014/01/05 01:42:55, dak wrote: > https://codereview.appspot.com/41990043/diff/60001/ly/satb.ly > File ly/satb.ly (right): > > https://codereview.appspot.com/41990043/diff/60001/ly/satb.ly#newcode1 > ...
10 years, 3 months ago (2014-01-05 09:27:27 UTC) #20
Devon Schudy
dak wrote: > https://codereview.appspot.com/41990043/diff/60001/ly/satb.ly#newcode97 > ly/satb.ly:97: \new Staff = #(identity ,name) \with { > Why ...
10 years, 3 months ago (2014-01-06 22:54:01 UTC) #21
dak
Devon Schudy <dschudy@gmail.com> writes: > dak wrote: >> https://codereview.appspot.com/41990043/diff/60001/ly/satb.ly#newcode97 >> ly/satb.ly:97: \new Staff = #(identity ...
10 years, 3 months ago (2014-01-06 23:26:51 UTC) #22
Devon Schudy
David Kastrup wrote: > At any rate, I'm not really happy with the macro usage ...
10 years, 3 months ago (2014-01-12 08:05:30 UTC) #23
dak
On 2014/01/12 08:05:30, Devon Schudy wrote: > David Kastrup wrote: > > At any rate, ...
10 years, 3 months ago (2014-01-12 08:59:46 UTC) #24
Trevor Daniels
10 years, 3 months ago (2014-01-12 09:17:31 UTC) #25
Message was sent while issue was closed.
On 2014/01/12 08:59:46, dak wrote:

> How about
> define-variables =
> #(define-void-function (parser location syms) (symbol-list?)
>    (for-each
>       (lambda (sym)
>         (if (null? (ly:parser-lookup parser sym))
>             (ly:parser-define parser sym *unspecified*)))))
> 
> If you write \name for a variable with value *unspecified*, it simply
disappears
> in the lexer.

Thanks both.  This issue is closed, but I'll check out
this solution and raise a new issue to incorporate it

Trevor
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b