Simplified version of Trevor Daniels' SATB framework.

Simplified version of Trevor Daniels' SATB framework.

* No separate init files.
* S-A-T-B and SA-TB are one file. The number of voices per staff is controlled by defining TwoVoicesPerStaff = ##t.
* Rename "Ladies" to "Women".
* Each voice has a separate instrument name.
* Short names default to the first character of the long name.
* Use default paper.
* Remove TopMarkup.
* Use clarinet instead of choir aahs/oohs, because it has clearer attacks.

[Trevor Daniels, 2013-12-17 22:50:13]

Thanks Devon - there's a lot in here that potentially
is an improvement, but also some things that will need
further work.  For example, a quick test of an existing
file of mine which used S-A-T-B.ily, placed the lyrics
above instead of below the staves.  I'll need to play
with it a bit more to see if there are any other
problems.  It also seems to have only one line of
lyrics in the 4-staff layout rather than two or three
(needed for translations and/or phonetics), unless I've
missed something.

What we lose with this approach is transparancy.
With straight Lily code, the more adventurous users
could adapt the template to suit their personal
preferances.  With this, only Schemers can.  But
as that wasn't the primary intention, it's not a
strong point against.

So, give me a day or two and I'll respond more
fully.  Hopefully we can converge on a mututally
acceptable solution.

Trevor

[Trevor Daniels, 2013-12-17 23:36:02]

I've now got a clean compile of a simple
four-staff SATB score, with the changes
shown.

More tests to follow, probably tomorrow ...

Trevor

https://codereview.appspot.com/38720045/diff/1/ly/satb.ly
File ly/satb.ly (right):

https://codereview.appspot.com/38720045/diff/1/ly/satb.ly#newcode78
ly/satb.ly:78: (let ((above (if (pair? optionals) (car optionals))))
This should be
  (let ((above (if (pair? optionals) (car optionals) #f)))
to avoid error messages

https://codereview.appspot.com/38720045/diff/1/ly/satb.ly#newcode98
ly/satb.ly:98: \voiceOne
This should be \oneVoice

https://codereview.appspot.com/38720045/diff/1/ly/satb.ly#newcode103
ly/satb.ly:103: #(lyrics-if-defined ,(sym name "Lyrics") ,name)
This should be
     #(lyrics-if-defined ,(sym name "Lyrics"))
otherwise the lyrics go above the staff.

[Devon Schudy, 2013-12-18 00:41:19]

Fix bugs. More verses. Implicit \lyricsto.

[Trevor Daniels, 2013-12-18 18:10:47]

This looks really good now.  I've tried
out pretty well all the combinations and
I have only nitpicking comments to make!

One suggestion: what do you think about
making LyricsOne a synonym for Lyrics?

@Devon
How to proceed?  The documentation in my
patch will need amending to correspond with
this improved template - I'm happy to do that
if you would like to guide this template
through review and into LP.  Alternatively
I could adopt this template (with appropriate
credits to you) and incorporate it as a 
replacement template together with doc changes
in my patch.  Whichever you prefer.

Many thanks for turning my simple approach
into a properly engineered solution.

Trevor

https://codereview.appspot.com/38720045/diff/20001/ly/satb.ly
File ly/satb.ly (right):

https://codereview.appspot.com/38720045/diff/20001/ly/satb.ly#newcode15
ly/satb.ly:15: Tenor and bass (optionally on one staff)
Bass

https://codereview.appspot.com/38720045/diff/20001/ly/satb.ly#newcode37
ly/satb.ly:37: etc
Perhaps more explicitly:
etc -> ...
VerseNine = \lyricmode { ... }

https://codereview.appspot.com/38720045/diff/20001/ly/satb.ly#newcode42
ly/satb.ly:42: PianoRHMusic = \relative { ... }
Follow with
PianoDynamics = { ... }

https://codereview.appspot.com/38720045/diff/20001/ly/satb.ly#newcode47
ly/satb.ly:47: All of the definitions are optional. Stavef with no music will be
Staves

[Trevor Daniels, 2013-12-18 22:34:16]

I'm not sure about using the default paper 
margins.  The printed output goes very close
to the left margin and the bottom of the bass
staff is cut off on some pages.  Either LP's
defaults should be changed or we include the
values I suggested originally in my templates
in https://codereview.appspot.com/41990043/ .

On balance I'd prefer to change them in the
template, on the grounds that they are tailored
for SATB layouts whereas the LP defaults may
be more suited to other forms of music.

Trevor

[Carl P., 2013-12-18 22:54:05]

On Wed, Dec 18, 2013 at 5:34 PM,  <tdanielsmusic@googlemail.com> wrote:
> I'm not sure about using the default paper
> margins.  The printed output goes very close
> to the left margin and the bottom of the bass
> staff is cut off on some pages.  Either LP's
> defaults should be changed or we include the
> values I suggested originally in my templates
> in https://codereview.appspot.com/41990043/ .
>
> On balance I'd prefer to change them in the
> template, on the grounds that they are tailored
> for SATB layouts whereas the LP defaults may
> be more suited to other forms of music.
>

I'm not sure I agree. I think for maximum utility, the template should
define as little as possible regarding the physical dimensions of the
page and margin, so that the user can use whatever style they want.
For instance, I use a 1/4 inch margin on a half-letter format
normally, but a 3/4 inch margin or so on a full letter size page. If
the point is to simplify vocal scores, do the minimum required to
produce the vocal score and leave the rest alone.

Carl P.

[t.daniels_treda.co.uk, 2013-12-18 23:48:12]

Carl Peterson wrote Wednesday, December 18, 2013 10:54 PM

> I'm not sure I agree. I think for maximum utility, the template should
> define as little as possible regarding the physical dimensions of the
> page and margin, so that the user can use whatever style they want.

But if the user is going to define his/her own \paper block the
defaults will be overridden anyway - having them would do
no harm nor cause more work for them.

> For instance, I use a 1/4 inch margin on a half-letter format
> normally, but a 3/4 inch margin or so on a full letter size page. If
> the point is to simplify vocal scores, do the minimum required to
> produce the vocal score and leave the rest alone.

Well, the point is rather to enable the user to do the minimum
required to produce a vocal score.  LP already has an A4
default output, so setting margins by default to suit that, rather
than _requiring_ a user to learn about \paper would definitely help
newcomers.  (The NR section on \paper is pretty daunting for
a newcomer!  And it's not even mentioned in the LM.)

Trevor

[Devon Schudy, 2013-12-19 16:18:53]

Improve comments. Add VerseOne. Fix piano MIDI instrument.

[Devon Schudy, 2013-12-19 16:25:09]

Trevor Daniels wrote:
> What we lose with this approach is transparancy. With straight Lily
> code, the more adventurous users could adapt the template to suit
> their personal preferances. With this, only Schemers can.

Yeah, this is a problem. Something like Janek's predefined staves would make it
much simpler.

> what do you think about making LyricsOne a synonym for Lyrics?

Yes.

> Alternatively I could adopt this template (with appropriate credits
> to you) and incorporate it as a replacement template together with
> doc changes in my patch.

Sure, go ahead.

> The printed output goes very close to the left margin

This is a common problem — it happens whenever shortInstrumentName is used — so
it really ought to be fixed in general. (It's issue 766.) The obvious thing to
do is to automatically increase the indent to fit the (short)InstrumentName. Is
it possible to communicate this from somewhere that knows about grobs to the
code that determines indents (apparently line_dimensions_int or its callers)?
(Or involve instrument names in layout, but that looks hard.

> and the bottom of the bass staff is cut off on some pages.

? When does this happen?