Issue 4191044: code review 4191044: A+C: Olivier Antoine (individual CLA)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4191044: code review 4191044: A+C: Olivier Antoine (individual CLA) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by rsc

Modified:
14 years, 3 months ago

Reviewers:

CC:
r, r2, golang-dev

Visibility:
Public.

Description

A+C: Olivier Antoine (individual CLA) Also sort name lists.

Patch Set 1 #

Patch Set 2 : diff -r 72d7040cd80c https://go.googlecode.com/hg #

Patch Set 3 : diff -r 72d7040cd80c https://go.googlecode.com/hg #

Patch Set 4 : diff -r d3bc87b547a4 https://go.googlecode.com/hg #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	AUTHORS	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
	M	CONTRIBUTORS	View	1	6 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

14 years, 3 months ago (2011-02-16 19:02:14 UTC) #1

rsc

*** Submitted as 7ac3d677ee18 *** A+C: Olivier Antoine (individual CLA) Also sort name lists. R=r, ...

14 years, 3 months ago (2011-02-16 20:02:13 UTC) #3

rsc

14 years, 3 months ago (2011-02-16 20:03:29 UTC) #4

> people can't sort

programs can't sort either.
i had to use

X /Please keep the list sorted/+2,|sed 's/Péter/Peter/' | sort -fu |
sed 's/Peter Sz/Péter Sz/

Expand All Messages | Collapse All Messages