Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(127)

Issue 4188056: DOC: NR 1.5.2 Multiple voices - part combining (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by Colin Campbell
Modified:
13 years ago
Reviewers:
james.lowe, Graham Percival (old account), reinhold, Trevor Daniels, Reinhold, pkx166h, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

DOC: NR 1.5.2 Multiple voices - part combining Adds explanations and examples of part combine functions to NR 1.5.2 Multiple voices - Automatic part combining Patch based on issue 4132045 by Reinhold

Patch Set 1 #

Total comments: 4

Patch Set 2 : DOC: minor revision of NR 1.5.2 #

Total comments: 22

Patch Set 3 : DOC: revisions to NR 1.5.2 partcombine commands #

Total comments: 2

Patch Set 4 : DOC revisions to partcombining #

Total comments: 1

Patch Set 5 : DOC NR 1.5.2 revised #

Total comments: 2

Patch Set 6 : Minor revisions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -2 lines) Patch
M Documentation/notation/simultaneous.itely View 1 2 3 4 5 2 chunks +66 lines, -2 lines 0 comments Download

Messages

Total messages: 25
Colin Campbell
Add documentation of partcombine functions. See issue 1518 on the bug tracker.
13 years, 1 month ago (2011-02-16 03:04:13 UTC) #1
Graham Percival (old account)
LGTM. http://codereview.appspot.com/4188056/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4188056/diff/1/Documentation/notation/simultaneous.itely#newcode846 Documentation/notation/simultaneous.itely:846: change the state permanently. Hmm. 5 commas in ...
13 years, 1 month ago (2011-02-16 03:50:29 UTC) #2
Keith
Looks good as it is, better if you can add one markup that Reinhold missed ...
13 years, 1 month ago (2011-02-16 06:08:03 UTC) #3
Reinhold
http://codereview.appspot.com/4188056/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4188056/diff/1/Documentation/notation/simultaneous.itely#newcode846 Documentation/notation/simultaneous.itely:846: change the state permanently. On 2011/02/16 03:50:29, Graham Percival ...
13 years, 1 month ago (2011-02-16 10:54:15 UTC) #4
Colin Campbell
On 2011/02/16 06:08:03, Keith wrote: > Looks good as it is, > better if you ...
13 years, 1 month ago (2011-02-16 13:53:26 UTC) #5
pkx166h
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode846 Documentation/notation/simultaneous.itely:846: change the state permanently. If I may make a ...
13 years, 1 month ago (2011-02-21 17:56:04 UTC) #6
Colin Campbell
revised patch uploaded. http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode846 Documentation/notation/simultaneous.itely:846: change the state permanently. On 2011/02/21 ...
13 years, 1 month ago (2011-02-21 20:29:42 UTC) #7
pkx166h
one correction. http://codereview.appspot.com/4188056/diff/2004/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4188056/diff/2004/Documentation/notation/simultaneous.itely#newcode820 Documentation/notation/simultaneous.itely:820: unison (@notation{a due}) parts are marked by ...
13 years, 1 month ago (2011-02-22 11:23:44 UTC) #8
Reinhold
http://codereview.appspot.com/4188056/diff/2004/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4188056/diff/2004/Documentation/notation/simultaneous.itely#newcode820 Documentation/notation/simultaneous.itely:820: unison (@notation{a due}) parts are marked by default with ...
13 years, 1 month ago (2011-02-22 11:49:04 UTC) #9
Reinhold
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode852 Documentation/notation/simultaneous.itely:852: chord or unisono. On 2011/02/21 20:29:42, Colin Campbell wrote: ...
13 years, 1 month ago (2011-02-22 12:15:31 UTC) #10
Colin Campbell
On 2011/02/22 12:15:31, Reinhold wrote: > http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely > File Documentation/notation/simultaneous.itely (right): > > http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode852 > ...
13 years, 1 month ago (2011-02-24 04:29:24 UTC) #11
pkx166h
On 2011/02/24 04:29:24, Colin Campbell > Perhaps I should add something like: decide, but the ...
13 years, 1 month ago (2011-02-26 06:52:46 UTC) #12
James.Lowe_datacore.com
Hello, ________________________________________ From: lilypond-devel-bounces+james.lowe=datacore.com@gnu.org [lilypond-devel-bounces+james.lowe=datacore.com@gnu.org] on behalf of pkx166h@gmail.com [pkx166h@gmail.com] Sent: 26 February 2011 06:52 ...
13 years, 1 month ago (2011-02-26 11:23:00 UTC) #13
Colin Campbell
> Actually thinking about it more would it make more sense to have the auto ...
13 years, 1 month ago (2011-02-26 20:01:39 UTC) #14
Carl
On 2011/02/26 20:01:39, Colin Campbell wrote: > I like that very much, James, thanks! A ...
13 years, 1 month ago (2011-02-26 20:10:30 UTC) #15
reinhold_kainhofer.com
Am Samstag, 26. Februar 2011, um 21:01:40 schrieben Sie: > A question for Reinhold, though: ...
13 years, 1 month ago (2011-02-26 20:38:38 UTC) #16
Graham Percival (old account)
http://codereview.appspot.com/4188056/diff/20001/scripts/auxiliar/doc-section.sh File scripts/auxiliar/doc-section.sh (right): http://codereview.appspot.com/4188056/diff/20001/scripts/auxiliar/doc-section.sh#newcode33 scripts/auxiliar/doc-section.sh:33: FROMDIR="$HOME/lilypond-git" I totally agree that this should be done, ...
13 years, 1 month ago (2011-02-28 10:15:11 UTC) #17
Colin Campbell
Patch revised to remove the doc-section.sh bits which were pushed separately. The remainder is just ...
13 years ago (2011-03-06 02:46:30 UTC) #18
Graham Percival (old account)
LGTM, let's push. Please send the final patch to James for pushing.
13 years ago (2011-03-06 08:24:43 UTC) #19
Trevor Daniels
LGTM, apart from a minor nitpick in original text http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (left): http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely#oldcode821 Documentation/notation/simultaneous.itely:821: ...
13 years ago (2011-03-06 09:31:14 UTC) #20
Reinhold
http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely#newcode871 Documentation/notation/simultaneous.itely:871: previous part combining mechanism. Actually, it never returns to ...
13 years ago (2011-03-06 12:13:15 UTC) #21
Colin Campbell
On 2011/03/06 12:13:15, Reinhold wrote: > http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely > File Documentation/notation/simultaneous.itely (right): > > http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely#newcode871 > ...
13 years ago (2011-03-07 01:38:36 UTC) #22
pkx166h
Layout wise - Looks fine.
13 years ago (2011-03-07 19:48:23 UTC) #23
Colin Campbell
On 2011/03/07 19:48:23, J_lowe wrote: > Layout wise - Looks fine. Colin, From: Colin Campbell ...
13 years ago (2011-03-11 02:29:16 UTC) #24
Reinhold
13 years ago (2011-03-11 16:32:12 UTC) #25
On 2011/03/07 01:38:36, Colin Campbell wrote:
> Ah, I was thinking that \partcombineautomatic once would go automatic for one
> note, then return to whatever was in force before it was called.  If you would
> confirm that, I'll reword the explanation to suit.

Yes, that's exactly how it works:
-) \partcombineAutomatic resets the part-combiner to use the default built-in
mechanism.
-) \partcombineAutomaticOnce uses the built-in mechanism for just one moment.

Your wording:
> @code{\partcombineAutomatic}, @code{\partcombineAutomaticOnce}:
>  Ends the effect of the special commands above, and returns to the default or
>  previous part combining mechanism.

sounds wrong for the *Once case, as the *once case does NOT end the effect of
the special commands above... It rather overrides the setting from those
commands for just one moment.

Cheers,
Reinhold
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b