Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(39)

Issue 4186050: Fix #1490. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by Neil Puttock
Modified:
13 years, 2 months ago
Reviewers:
Graham Percival (old account), carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix #1490. Don't discard labels set on columns which are currently pruned or fall on an empty barline. * input/regression (page-label-loose-column.ly) new regtest, checks both unbreakable mid-line and empty barline labels * lily/include/system.hh: add collect_labels () * lily/paper-column.cc (is_used): return true if 'labels is set * lily/spacing-determine-loose-columns.cc (prune_loose_columns): set 'maybe-loose on columns which only contain page-labels * lily/system.cc (break_into_pieces, collect_labels): collect labels from loose columns move label collection to separate method

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -3 lines) Patch
A input/regression/page-label-loose-column.ly View 1 chunk +17 lines, -0 lines 0 comments Download
M lily/include/system.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/paper-column.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M lily/spacing-determine-loose-columns.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M lily/system.cc View 2 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 4
Neil Puttock
Hi everybody, This patch ensures page labels aren't ignored on mid-line unbreakable columns (between notes ...
13 years, 2 months ago (2011-02-14 23:08:50 UTC) #1
Graham Percival (old account)
LGTM
13 years, 2 months ago (2011-02-15 01:06:30 UTC) #2
Carl
LGTM Carl
13 years, 2 months ago (2011-02-15 01:22:35 UTC) #3
Graham Percival (old account)
13 years, 2 months ago (2011-02-17 18:32:21 UTC) #4
Please push.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b