Doc: harmonics and slides

harmonics and slides

new patch
	# This will displayed on the codereview site.

harmonics-and-slides-V

include file for chord glissando

harmonics-and-slides-IV

new snippets

harmonics-and-slides-III

Revision of old patch

[Graham Percival (old account), 2011-02-14 22:21:27]

initial review.

http://codereview.appspot.com/4186049/diff/1/Documentation/notation/fretted-s...
File Documentation/notation/fretted-strings.itely (right):

http://codereview.appspot.com/4186049/diff/1/Documentation/notation/fretted-s...
Documentation/notation/fretted-strings.itely:389: Please note that the command
@code{\harmonic} must always be defined inside a chord construct. It only makes
sense for open-string harmonics in the 12th fret. All other harmonics should be
calculated by LilyPond. This can be achieved by indicating the fret where a
finger of the fretting hand should touch a string.
Could we get linebreaks at 72 characters, instead of having everything on one
line?

http://codereview.appspot.com/4186049/diff/1/Documentation/snippets/new/tabla...
File Documentation/snippets/new/tablature-chord-glissando.ly (right):

http://codereview.appspot.com/4186049/diff/1/Documentation/snippets/new/tabla...
Documentation/snippets/new/tablature-chord-glissando.ly:3: \header {
We need some lsrtags in here.  See other files in Documentation/snippets/new/
for examples.

http://codereview.appspot.com/4186049/diff/1/Documentation/snippets/new/tabla...
Documentation/snippets/new/tablature-chord-glissando.ly:9: % string numbers are
necessary for TabStaff because automatic
Any particular reason you don't want to include this text in the texidoc string?
 I think it might be useful to display it for readers.  The texidoc doesn't need
to be a single sentence.

http://codereview.appspot.com/4186049/diff/1/Documentation/snippets/new/tabla...
File Documentation/snippets/new/tablature-fretted-string-harmonics.ly (right):

http://codereview.appspot.com/4186049/diff/1/Documentation/snippets/new/tabla...
Documentation/snippets/new/tablature-fretted-string-harmonics.ly:9: PH = {
What does "PH" mean?  Is this a very typical abbreviation for guitarists? 
unless you think that everybody will understand it, it might be nice to expand
the name into something like "primaryHand" (if that's what it means).

[pls, 2011-02-28 09:56:05]

Hi Graham,

here is a revised patch.

Cheers,
patrick

[Graham Percival (old account), 2011-02-28 10:10:02]

I had to run
  scripts/makelsr.py
before I could compile this patch.  Please do the same, then do:
  git add Documentation/snippets/*.ly
  git commit .
and upload a new patch.

Other than that, LGTM.

[pls, 2011-02-28 11:01:22]

Is it ok, now?

Thanks,
patrick

[Graham Percival (old account), 2011-02-28 11:13:50]

LGTM

[pkx166h, 2011-02-28 13:21:22]

One comment.

Thanks for your time.

http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/frette...
File Documentation/notation/fretted-strings.itely (right):

http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/frette...
Documentation/notation/fretted-strings.itely:427: @end lilypond
Apologies for my ignorance on fretted music, but is there a reason we need both
the \ottava #1 and the \clef "treble_8" functions in this?

That is, can we omit one/all of them and still make the example make sense?

I know it seems trivial but it does make the @lilypond even simpler and more
compact.

[Trevor Daniels, 2011-02-28 13:46:05]

LGTM.
Just one trivial nitpick.

http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/frette...
File Documentation/notation/fretted-strings.itely (right):

http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/frette...
Documentation/notation/fretted-strings.itely:389: Please note that the command
@code{\harmonic} must always be defined
No need for 'Please'

[pls, 2011-02-28 19:16:31]

Am 28.02.2011 um 14:21 schrieb pkx166h@gmail.com:

> One comment.
> 
> Thanks for your time.
> 
> 
>
http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/frette...
> File Documentation/notation/fretted-strings.itely (right):
> 
>
http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/frette...
> Documentation/notation/fretted-strings.itely:427: @end lilypond
> Apologies for my ignorance on fretted music, but is there a reason we
> need both the \ottava #1 and the \clef "treble_8" functions in this?
> 
> That is, can we omit one/all of them and still make the example make
> sense?
Hm, we could omit all of them but this might be confusing for guitarists.
Guitarists normally read music as if there were a "treble_8" even when there is
a "treble"-clef. I probably included the \ottava #1 in one of my first snippets
to avoid very high notes. But in this case it is not really necessary, indeed!

Thanks,
patrick
> 
> I know it seems trivial but it does make the @lilypond even simpler and
> more compact.
> 
> http://codereview.appspot.com/4186049/
> 

[pls, 2011-02-28 21:00:15]

Hi all,

here is a revised patch. I hope everything is ok now. I don't know why two files
I did not alter are part of this patch:
hymn-template.ly and partcombine-and-autobeamoff.ly.

BTW I accidentally created another issue number (4245047). Sorry for that. How
can I delete it?

Thanks for your help!
patrick

[Graham Percival (old account), 2011-03-04 12:33:46]

Looks good, and there's no complaints.  Could you send me the full patch for
pushing?

[pls, 2011-03-04 13:07:36]

Thanks for your help!

patrick

[Graham Percival (old account), 2011-06-08 19:12:59]

Could you officially close this issue?  I think it's been pushed.

[pls, 2011-06-08 19:55:45]

Hi Graham,

I recently got a new gmail-address. Thanks to google (I love you!) I can still
log in with my old email address but rietveld automatically uses my
gmail-account with a new nickname/user name. So unfortunately I don't see any
way to edit/close the issue.

Help appreciated?!

Thx
patrick
Am 08.06.2011 um 21:12 schrieb percival.music.ca@gmail.com:

> Could you officially close this issue?  I think it's been pushed.
> 
> http://codereview.appspot.com/4186049/