Issue 4185054: code review 4185054: net: refactor windows code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4185054: code review 4185054: net: refactor windows code (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by brainman

Modified:
14 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

net: refactor windows code

Patch Set 1 #

Patch Set 2 : diff -r 231c6b6747d6 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 206a2622c6cb https://go.googlecode.com/hg/ #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+314 lines, -372 lines)			Patch
M	src/pkg/net/fd_windows.go	View	1	10 chunks	+313 lines, -352 lines	0 comments	Download
M	src/pkg/syscall/syscall_windows.go	View	1	1 chunk	+0 lines, -20 lines	0 comments	Download
M	src/pkg/syscall/ztypes_windows_386.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 3 months ago (2011-02-17 06:40:15 UTC) #1

rsc

LGTM I don't claim to understand all the Windows API stuff. But it looks fine.

14 years, 2 months ago (2011-02-22 21:02:58 UTC) #2

brainman

*** Submitted as http://code.google.com/p/go/source/detail?r=4c45d4ff1665 *** net: refactor windows code R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/4185054

14 years, 2 months ago (2011-02-23 03:40:30 UTC) #3

brainman

14 years, 2 months ago (2011-02-23 03:44:58 UTC) #4

On 2011/02/22 21:02:58, rsc wrote:
> LGTM
> 
> I don't claim to understand all the Windows API stuff.
> But it looks fine.

Thank you for looking <g>.

Expand All Messages | Collapse All Messages