code review 4183053: reflect: add a couple of sentences explaining how Metho...

reflect: add a couple of sentences explaining how Methods operate.

[r, 2011-02-16 01:08:14]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2011-02-16 01:12:11]

FYI

http://codereview.appspot.com/4183053/diff/1/src/pkg/reflect/type.go
File src/pkg/reflect/type.go (right):

http://codereview.appspot.com/4183053/diff/1/src/pkg/reflect/type.go#newcode191
src/pkg/reflect/type.go:191: // of T and the receiver type will be PtrType
representing a *T.
... be a PtrType representing *T.

or

... be the PtrType representing a *T.

[r, 2011-02-16 01:53:04]

Hello rsc, gri (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2011-02-16 06:04:46]

http://codereview.appspot.com/4183053/diff/5001/src/pkg/reflect/type.go
File src/pkg/reflect/type.go (right):

http://codereview.appspot.com/4183053/diff/5001/src/pkg/reflect/type.go#newco...
src/pkg/reflect/type.go:188: // The FuncType's first argument represents the
receiver; to call the method,
This part probably belongs below in the definition of Method(i int).
I don't believe it is true of interface methods, for example.
The description of Method below tries to establish the two cases
already but it should be clarified.  One possibility:

// Method returns the i'th method in the type's method set.
// NumMethods returns the number of methods in the type's method set.
//
// For a non-interface type T or *T, the returned Method's Type and Func
// fields describe a function whose first argument is the receiver.
//
// For an interface type, the returned Method's Type field gives the
// method signature, without a receiver, and the Func field is nil.

[bsiegert, 2011-02-16 07:57:49]

Just a grammmar nitpick.

http://codereview.appspot.com/4183053/diff/5001/src/pkg/reflect/type.go
File src/pkg/reflect/type.go (right):

http://codereview.appspot.com/4183053/diff/5001/src/pkg/reflect/type.go#newco...
src/pkg/reflect/type.go:188: // The FuncType's first argument represents the
receiver; to call the method,
The first argument of Type?

http://codereview.appspot.com/4183053/diff/5001/src/pkg/reflect/type.go#newco...
src/pkg/reflect/type.go:189: // the receiver is provided as the first argument
to the FuncValue.  If the
the first argument to Func?

[r, 2011-02-16 18:57:37]

Hello rsc, gri, rsc1, bsiegert (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2011-02-16 18:58:10]

Hello rsc, gri, rsc1, bsiegert (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-02-16 19:00:50]

LGTM

[r, 2011-02-16 19:01:27]

*** Submitted as http://code.google.com/p/go/source/detail?r=5ea88e383a70 ***

reflect: add a couple of sentences explaining how Methods operate.

R=rsc, gri, rsc1, bsiegert
CC=golang-dev
http://codereview.appspot.com/4183053