code review 4183047: build: run test/ directory first

build: run test/ directory first

[rsc, 2011-02-11 23:01:10]

Hello adg, r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[r, 2011-02-11 23:03:34]

I thought of this a while back and decided not to do it.  The tests in
test/ are small tests, mostly compiler-related, and rarely break.  I
almost never see a breakage there that isn't caught by the package
tests.  On the other hand, package tests test the packages, which are
where most of the editing goes and most of the bugs happen.  I say the
order is right as it stands.

For compiler writers I would favor a flag to invert the order, but the
current order should be the default.

-rob

[rsc, 2011-02-11 23:07:26]

On Fri, Feb 11, 2011 at 18:03, Rob 'Commander' Pike <r@golang.org> wrote:
> I thought of this a while back and decided not to do it.  The tests in
> test/ are small tests, mostly compiler-related, and rarely break.  I
> almost never see a breakage there that isn't caught by the package
> tests.  On the other hand, package tests test the packages, which are
> where most of the editing goes and most of the bugs happen.  I say the
> order is right as it stands.

Okay.  I'd still like to change the docs and the final print so
that it is clearer when everything is okay.

[rsc, 2011-02-11 23:07:32]

Hello adg, r (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2011-02-12 00:17:04]

LGTM

[adg, 2011-02-13 21:34:02]

LGTM

[rsc, 2011-02-14 14:27:10]

*** Submitted as acf4d0a7130f ***

build: run test/ directory first

R=adg, r
CC=golang-dev
http://codereview.appspot.com/4183047

[r, 2011-02-14 17:13:00]

the CL description is incorrect. remember that when you put the next
release together.