Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(142)

Issue 4182047: code review 4182047: runtime: stop when running out of threads on Windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by brainman
Modified:
14 years, 10 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

runtime: stop when running out of threads on Windows

Patch Set 1 #

Patch Set 2 : diff -r 4decd02fda70 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4decd02fda70 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3e788cf7bb2d https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 3e788cf7bb2d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/pkg/runtime/windows/thread.c View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 8
brainman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 10 months ago (2011-02-11 03:18:02 UTC) #1
rsc
Can you make the message look like the one on OS X, reporting the number ...
14 years, 10 months ago (2011-02-11 14:39:30 UTC) #2
brainman
Hello golang-dev@googlegroups.com, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 10 months ago (2011-02-12 09:14:18 UTC) #3
brainman
On 2011/02/11 14:39:30, rsc wrote: > Can you make the message look like the one ...
14 years, 10 months ago (2011-02-12 09:15:01 UTC) #4
rsc
LGTM
14 years, 10 months ago (2011-02-14 17:13:39 UTC) #5
rsc
fixes issue 1495
14 years, 10 months ago (2011-02-14 17:13:59 UTC) #6
brainman
*** Submitted as http://code.google.com/p/go/source/detail?r=773c9891ff7a *** runtime: detect failed thread creation on Windows Fixes issue 1495. ...
14 years, 10 months ago (2011-02-14 22:42:33 UTC) #7
brainman
14 years, 10 months ago (2011-02-14 22:42:59 UTC) #8
On 2011/02/14 17:13:59, rsc wrote:
> fixes issue 1495

Done. Thanks you for review.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b