Issue 4180057: code review 4180057: fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4180057: code review 4180057: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by rsc

Modified:
14 years, 3 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

fix build pieces of an upcoming CL leaked into CL 4168056

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
M	src/cmd/5l/obj.c	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	src/cmd/6l/obj.c	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	src/cmd/8l/obj.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

14 years, 3 months ago (2011-02-18 17:37:15 UTC) #1

rsc

*** Submitted as 872a4116038c *** fix build pieces of an upcoming CL leaked into CL ...

14 years, 3 months ago (2011-02-18 17:37:23 UTC) #2

LGTM