Issue 4180052: code review 4180052: syscall: fix windows SetFileAttributes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4180052: code review 4180052: syscall: fix windows SetFileAttributes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by brainman

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc, hector, mattn

Visibility:
Public.

Description

syscall: fix windows SetFileAttributes

Patch Set 1 #

Patch Set 2 : diff -r 4892f94182a5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4892f94182a5 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 4892f94182a5 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r e8ae44f3e5de https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -23 lines)			Patch
	M	src/pkg/syscall/syscall_windows.go	View	1 2 3 4	3 chunks	+18 lines, -21 lines	0 comments	Download
	M	src/pkg/syscall/zsyscall_windows_386.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com (cc: hector, mattn), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2011-02-16 23:10:09 UTC) #1

hector

I looked at Chmod again and found these two warts. Apologies for raising these after ...

13 years, 2 months ago (2011-02-16 23:34:09 UTC) #4

brainman

Hello golang-dev@googlegroups.com, rsc, hector (cc: golang-dev@googlegroups.com, mattn), Please take another look.

13 years, 2 months ago (2011-02-16 23:44:55 UTC) #5

brainman

On 2011/02/16 23:50:48, hector wrote: > LGTM Thank you for review.

13 years, 2 months ago (2011-02-17 00:00:16 UTC) #7

brainman

13 years, 2 months ago (2011-02-17 01:09:19 UTC) #8

*** Submitted as http://code.google.com/p/go/source/detail?r=3385cc7c49e6 ***

syscall: fix windows SetFileAttributes

R=golang-dev, rsc, hector
CC=golang-dev, mattn
http://codereview.appspot.com/4180052

Expand All Messages | Collapse All Messages