Issue 4179043: code review 4179043: crypto/openpgp: minor updates to subpackages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4179043: code review 4179043: crypto/openpgp: minor updates to subpackages (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by agl1

Modified:
14 years, 8 months ago

Reviewers:

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

crypto/openpgp: minor updates to subpackages Now that packet/ is checked in, we can add its Makefile. Also, a couple of updates to error/ and s2k/ for bugfixes and to use the new crypto package.

Patch Set 2 : diff -r 4decd02fda70 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4decd02fda70 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 4 : diff -r bc285bf0784d https://go.googlecode.com/hg/ #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -26 lines)			Patch
M	src/pkg/crypto/openpgp/error/error.go	View	1	2 chunks	+18 lines, -0 lines	0 comments	Download
A	src/pkg/crypto/openpgp/packet/Makefile	View	1 2	1 chunk	+22 lines, -0 lines	0 comments	Download
M	src/pkg/crypto/openpgp/s2k/s2k.go	View	1 2 3	3 chunks	+40 lines, -26 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

LGTM http://codereview.appspot.com/4179043/diff/5001/src/pkg/crypto/openpgp/s2k/s2k.go File src/pkg/crypto/openpgp/s2k/s2k.go (right): http://codereview.appspot.com/4179043/diff/5001/src/pkg/crypto/openpgp/s2k/s2k.go#newcode127 src/pkg/crypto/openpgp/s2k/s2k.go:127: // OpenPGP's. See RFC 4880, section 9.4. s/OpenPGP/Go's ...

14 years, 8 months ago (2011-02-11 01:45:39 UTC) #2

agl1

Hello bradfitzgo (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 8 months ago (2011-02-11 13:34:18 UTC) #3

agl1

14 years, 8 months ago (2011-02-11 13:34:29 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=d380d217ce15 ***

crypto/openpgp: minor updates to subpackages

Now that packet/ is checked in, we can add its Makefile. Also, a couple
of updates to error/ and s2k/ for bugfixes and to use the new crypto
package.

R=bradfitzgo
CC=golang-dev
http://codereview.appspot.com/4179043

http://codereview.appspot.com/4179043/diff/5001/src/pkg/crypto/openpgp/s2k/s2...
File src/pkg/crypto/openpgp/s2k/s2k.go (right):

http://codereview.appspot.com/4179043/diff/5001/src/pkg/crypto/openpgp/s2k/s2...
src/pkg/crypto/openpgp/s2k/s2k.go:127: // OpenPGP's. See RFC 4880, section 9.4.
On 2011/02/11 01:45:39, bradfitzgo wrote:
> s/OpenPGP/Go's hash.Hash type/ ?

Yep, thanks.

http://codereview.appspot.com/4179043/diff/5001/src/pkg/crypto/openpgp/s2k/s2...
src/pkg/crypto/openpgp/s2k/s2k.go:149: return crypto.Hash(0), false
On 2011/02/11 01:45:39, bradfitzgo wrote:
> why not nil, false here?  I see that crypto.Hash(0).New() will return nil, but
> what's the benefit of returning non-nil here?

crypto.Hash isn't an interface type, it's a uint so nil doesn't work. 0 does
though, so I used that.

Expand All Messages | Collapse All Messages