code review 4177042: http/server: replace OS-specific path separator to URL'...

http/server: replace OS-specific path separator to URL's one.

[mattn, 2011-02-10 02:46:13]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
http://go.googlecode.com/hg/

[mattn, 2011-02-10 03:04:35]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-02-10 03:27:34]

http://codereview.appspot.com/4177042/diff/5002/src/pkg/http/server.go
File src/pkg/http/server.go (right):

http://codereview.appspot.com/4177042/diff/5002/src/pkg/http/server.go#newcod...
src/pkg/http/server.go:585: p = strings.Replace(p, string(path.DirSeps[0]), "/",
-1)
I'd like to take care of this, if you don't mind.

If package path is going to be OS-specific then we will need
to do something else here.  The directory separator is not the
only thing that changes by OS: on Windows we'd get weird
behavior with paths like c:/foo.  This code will need to be 
not OS-specific, so not using package path at all.

[dsymonds, 2011-02-10 03:31:01]

This isn't right. URLs are specified by RFC 2396, which mandates only
forward slashes (section 3). Even Windows is expected to use "/" for
URL paths.

[mattn, 2011-02-10 03:56:49]

http://codereview.appspot.com/4177042/diff/5002/src/pkg/http/server.go
File src/pkg/http/server.go (right):

http://codereview.appspot.com/4177042/diff/5002/src/pkg/http/server.go#newcod...
src/pkg/http/server.go:585: p = strings.Replace(p, string(path.DirSeps[0]), "/",
-1)
Yes, I think also.

But it will turn out to be that we provide two functions like below.

  PathToUrl() // relative os-specific path to URL
  UrlToPath   // else

And we'll have to add this to all of top in the part of manipulating URL & local
path.

Thanks.

On 2011/02/10 03:27:34, rsc wrote:
> I'd like to take care of this, if you don't mind.
> 
> If package path is going to be OS-specific then we will need
> to do something else here.  The directory separator is not the
> only thing that changes by OS: on Windows we'd get weird
> behavior with paths like c:/foo.  This code will need to be 
> not OS-specific, so not using package path at all.
>

[rsc, 2011-02-11 20:08:51]

removing reviewers; i will take care of this

[mattn, 2011-02-18 12:49:41]

*** Abandoned ***

[mattn, 2011-02-22 06:00:47]

This is workaround for win32.
on windows, panic() show JIT debug dialog. i don't like it. and it's
unhealthful.

http://awesomescreenshot.com/05f7zqhef

It is too difficual to put down the dialog from parent process.
DebugActiveProcess() and polling events, loop for ContinueDebugEvent().

I think that this is easy way to avoid it.

[mattn, 2011-02-22 06:01:16]

oops, sorry. I missed to reply.