Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1151)

Issue 4174043: Beam collision scoring (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by hanwenn
Modified:
13 years, 2 months ago
Reviewers:
Keith, MikeSol, wl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Beam collision scoring * Add separate scorer for horizontal inter quant * Split up slope scorers * Add collision precompute data and scoring pass * Add separate factor for lighter penalties of stem/beam collisions * Further decrease debug data fontsize * Add different testfiles.

Patch Set 1 #

Patch Set 2 : compiles. fix buglet #

Total comments: 1

Patch Set 3 : Fix most egregious failures of beam collision code, by guessing a reasonable start solution. #

Patch Set 4 : Fix most egregious failures of beam collision code, by guessing a reasonable start solution. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -22 lines) Patch
A input/regression/beam-collision-feasible-region.ly View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
A input/regression/beam-collision-opposite-stem.ly View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
M lily/beam.cc View 1 2 8 chunks +156 lines, -22 lines 0 comments Download

Messages

Total messages: 5
Keith
I tried this patch on half a dozen piano and orchestral scores and saw no ...
13 years, 2 months ago (2011-02-10 07:02:17 UTC) #1
Keith
On 2011/02/10 07:02:17, Keith wrote: > > (note_head); (accidental); (clef); (key_signature); > (time_signature); (bar_line); (beam); ...
13 years, 2 months ago (2011-02-10 07:21:31 UTC) #2
Keith
On 2011/02/10 07:21:31, Keith wrote: > > (note_head); (accidental); (clef); (key_signature); > (time_signature); (bar_line); (beam); ...
13 years, 2 months ago (2011-02-10 07:44:50 UTC) #3
hanwenn
2011/2/10 Werner LEMBERG <wl@gnu.org>: > >> I tried this patch on half a dozen piano ...
13 years, 2 months ago (2011-02-10 12:27:25 UTC) #4
wl_gnu.org
13 years, 2 months ago (2011-02-10 12:45:14 UTC) #5
> The problem is that this requires another layer of code.  The
> collision code works for beams individually.  For this to be
> resolved like this, there needs to be coordination between the two
> beams.  This is much harder, because many such collisions may be
> chained together, eg.
> 
> <<
>    { s8 c[ c] c[ c] s8 } \\
>    { c[ c] c[ c] c[ ] }
>  >>

Hmm.  What about adding some commands to restrict such collosion
resolution horizontally?  I'm quite sure that most of the problems are
local, and the user knows in advance where it happens so that it can
be tagged with, say, \startFullBeamCollisionHandling and
\stopFullBeamCollisionHandling.


    Werner
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b