code review 4173043: crypto/openpgp/packet: add remainder of packet types.

crypto/openpgp/packet: add remainder of packet types.

(The unittest for Signature may seem a little small, but it's tested by
the higher level code.)

[bradfitz, 2011-02-10 18:26:48]

http://codereview.appspot.com/4173043/diff/2001/src/pkg/crypto/openpgp/packet...
File src/pkg/crypto/openpgp/packet/reader.go (right):

http://codereview.appspot.com/4173043/diff/2001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/reader.go:49: func (r *Reader) Push(reader
io.Reader) {
Somewhat weird to have this functionality here.

Seems more appropriate to add this to io.MultiReader, but that returns an
interface at the moment.  I suppose the internal multiReader struct could be
made public.  I think I recall seeing such a patch on the mailing list awhile
back.

http://codereview.appspot.com/4173043/diff/2001/src/pkg/crypto/openpgp/packet...
File src/pkg/crypto/openpgp/packet/signature.go (right):

http://codereview.appspot.com/4173043/diff/2001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/signature.go:396: // the message to be signed and
will be mutated by this function.
Maybe s/the message/the hash of the message/ ?

http://codereview.appspot.com/4173043/diff/2001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/signature.go:411: func (sig *Signature)
Serialise(w io.Writer) (err os.Error) {
Does Go use British or American spellings?  I thought the latter?

[agl1, 2011-02-11 00:59:11]

Hello bradfitzgo (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[agl1, 2011-02-11 00:59:23]

*** Submitted as http://code.google.com/p/go/source/detail?r=4decd02fda70 ***

crypto/openpgp/packet: add remainder of packet types.

(The unittest for Signature may seem a little small, but it's tested by
the higher level code.)

R=bradfitzgo
CC=golang-dev
http://codereview.appspot.com/4173043

http://codereview.appspot.com/4173043/diff/2001/src/pkg/crypto/openpgp/packet...
File src/pkg/crypto/openpgp/packet/reader.go (right):

http://codereview.appspot.com/4173043/diff/2001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/reader.go:49: func (r *Reader) Push(reader
io.Reader) {
On 2011/02/10 18:26:48, bradfitzgo wrote:
> Seems more appropriate to add this to io.MultiReader, but that returns an
> interface at the moment.  I suppose the internal multiReader struct could be
> made public.  I think I recall seeing such a patch on the mailing list awhile
> back.

This is somewhat different from a multi-reader in that new Readers can be added
during the read. I can't think of a nice way to merge them.

http://codereview.appspot.com/4173043/diff/2001/src/pkg/crypto/openpgp/packet...
File src/pkg/crypto/openpgp/packet/signature.go (right):

http://codereview.appspot.com/4173043/diff/2001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/signature.go:396: // the message to be signed and
will be mutated by this function.
On 2011/02/10 18:26:48, bradfitzgo wrote:
> Maybe s/the message/the hash of the message/ ?

Done.

http://codereview.appspot.com/4173043/diff/2001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/signature.go:411: func (sig *Signature)
Serialise(w io.Writer) (err os.Error) {
On 2011/02/10 18:26:48, bradfitzgo wrote:
> Does Go use British or American spellings?  I thought the latter?

z-ifed.