Add dots to tocItemMarkup

Add dots to tocItemMarkup

* New markup command fill-with-dots

* Add it to tocItemMarkup

[Graham Percival (old account), 2011-02-15 00:53:38]

LGTM.

[Carl, 2011-02-15 00:56:02]

I like the idea.

I think to become part of the distribution it needs to support both postscript
and svg.

Thanks,

Carl

http://codereview.appspot.com/4172047/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):

http://codereview.appspot.com/4172047/diff/1/scm/define-markup-commands.scm#n...
scm/define-markup-commands.scm:1033: #:with-dimensions (cons 0 middle-width) '(0
. 0) #:postscript (string-append "0.25 setlinewidth 1 setlinecap [0 1.5] 0
setdash " (number->string offset) " 0.12 moveto " (number->string middle-width)
" 0 rlineto stroke")
I don't think we should accept postscript markups as part of the distribution. 
They will break the SVG backend.

We should ask for all markup functions that become part of the distribution to
be supported in all backends, IMO.

[Patrick McCarty, 2011-02-15 02:37:52]

http://codereview.appspot.com/4172047/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):

http://codereview.appspot.com/4172047/diff/1/scm/define-markup-commands.scm#n...
scm/define-markup-commands.scm:1033: #:with-dimensions (cons 0 middle-width) '(0
. 0) #:postscript (string-append "0.25 setlinewidth 1 setlinecap [0 1.5] 0
setdash " (number->string offset) " 0.12 moveto " (number->string middle-width)
" 0 rlineto stroke")
On 2011/02/15 00:56:02, Carl wrote:
> I don't think we should accept postscript markups as part of the distribution.

> They will break the SVG backend.
> 
> We should ask for all markup functions that become part of the distribution to
> be supported in all backends, IMO. 

I agree.

Except for `setdash', the rest of the \postscript string argument can be written
with \path (and its arguments) instead.  This command supports both primary
backends.

[Bertrand Bordage, 2011-02-15 13:17:01]

Update on http://code.google.com/p/lilypond/issues/detail?id=1517

[Graham Percival (old account), 2011-02-15 17:50:53]

On 2011/02/15 13:17:01, Bertrand Bordage wrote:
> Update on http://code.google.com/p/lilypond/issues/detail?id=1517

I've added this to codereview.

Bertrand, could you upload it to codereview yourself, with a new codereview
issue number?  I think the instructions in the Contributor's Guide are fairly
clear about this point, and it would be nice if you could handle this stuff.

[Bertrand Bordage, 2011-02-15 19:14:18]

Yes, sorry...
I made a new codereview issue : http://codereview.appspot.com/4182056/


...(currently reading the Contributor's Guide again)...