Issue 4172041: code review 4172041: http: add Server type supporting timeouts

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4172041: code review 4172041: http: add Server type supporting timeouts (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by bradfitz

Modified:
14 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

http: add Server type supporting timeouts

Patch Set 2 : code review 4172041: http: add Server type supporting timeouts #

Total comments: 1

Patch Set 3 : code review 4172041: http: add Server type supporting timeouts #

Total comments: 5

Patch Set 4 : diff -r 32e6fff7fbb3 https://go.googlecode.com/hg/ #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -7 lines)			Patch
	M	src/pkg/http/serve_test.go	View	1 2 3	2 chunks	+66 lines, -0 lines	0 comments	Download
	M	src/pkg/http/server.go	View	1 2	3 chunks	+41 lines, -7 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2011-02-09 20:45:54 UTC) #1

bradfitz

http://codereview.appspot.com/4172041/diff/2001/src/pkg/http/server.go File src/pkg/http/server.go (right): http://codereview.appspot.com/4172041/diff/2001/src/pkg/http/server.go#newcode681 src/pkg/http/server.go:681: ReadTimeout int64 // ... description whoops, forgot this. (I'd ...

14 years, 3 months ago (2011-02-09 20:46:49 UTC) #2

bradfitz

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 3 months ago (2011-02-09 20:48:56 UTC) #3

rsc

LGTM http://codereview.appspot.com/4172041/diff/2002/src/pkg/http/serve_test.go File src/pkg/http/serve_test.go (right): http://codereview.appspot.com/4172041/diff/2002/src/pkg/http/serve_test.go#newcode303 src/pkg/http/serve_test.go:303: const quarterSecond = 250000000 /* nanos */ can ...

14 years, 3 months ago (2011-02-10 19:00:23 UTC) #4

bradfitz

14 years, 3 months ago (2011-02-10 22:36:25 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=260d43087237 ***

http: add Server type supporting timeouts

R=rsc
CC=golang-dev
http://codereview.appspot.com/4172041

Expand All Messages | Collapse All Messages