Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(400)

Issue 4168043: code review 4168043: json: correct Marshal documentation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by adg
Modified:
14 years, 3 months ago
Reviewers:
CC:
r, rsc, rog, golang-dev
Visibility:
Public.

Description

json: correct Marshal documentation Fixes issue 1488.

Patch Set 1 #

Patch Set 2 : diff -r 3972eb64f7cd https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/pkg/json/encode.go View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6
adg
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 3 months ago (2011-02-10 15:53:40 UTC) #1
rsc
LGTM
14 years, 3 months ago (2011-02-10 15:58:57 UTC) #2
rog
don't most JSON fields use lower case, at least for the first letter? maybe that ...
14 years, 3 months ago (2011-02-10 16:07:13 UTC) #3
rsc
On Thu, Feb 10, 2011 at 11:07, <rogpeppe@gmail.com> wrote: > don't most JSON fields use ...
14 years, 3 months ago (2011-02-10 16:08:54 UTC) #4
rog
LGTM On 10 February 2011 16:08, Russ Cox <rsc@golang.org> wrote: > On Thu, Feb 10, ...
14 years, 3 months ago (2011-02-10 16:11:57 UTC) #5
adg
14 years, 3 months ago (2011-02-10 18:48:16 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=9dda1be7ffa7 ***

json: correct Marshal documentation

Fixes issue 1488.

R=r, rsc, rog
CC=golang-dev
http://codereview.appspot.com/4168043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b