Issue 4160059: HACK DO NOT PUSH markuplines fix (Neil)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4160059: HACK DO NOT PUSH markuplines fix (Neil) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by Graham Percival (old account)

Modified:
13 years, 2 months ago

Reviewers:
Keith

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

HACK DO NOT PUSH markuplines fix (Neil)

Patch Set 1 #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	lily/parser.yy	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Graham Percival (old account)

Neil's fix for a critical crash with markuplines.

13 years, 2 months ago (2011-02-17 22:49:07 UTC) #1

Keith

13 years, 2 months ago (2011-02-20 21:44:56 UTC) #2

On 2011/02/17 22:49:07, Graham Percival wrote:
> Neil's fix for a critical crash with markuplines.

What's not to love?
It is recognizable even to a non-lexer like me as an illegal-value trap, and it
uses the same scm_is_pair idiom as similar tests in this file.

Expand All Messages | Collapse All Messages