Issue 4160048: Doc -- Clarify instructions on autobeam settings (Closed)
|
Created:
13 years, 2 months ago by Carl Modified:
13 years, 2 months ago CC:
lilypond-devel_gnu.org Visibility:
Public. |
DescriptionDoc -- Clarify instructions on autobeam settings
Multiple \time calls can revert custom autobeam settings. Clarify
in the documentation.
Patch Set 1 #
Total comments: 5
Patch Set 2 : Eliminate bad examples, move to @knownissues #
Total comments: 3
Patch Set 3 : Revise wording, fix typo #
Total comments: 1
MessagesTotal messages: 13
Mats identified some unexpected behavior with autobeam settings and time signature setting. http://thread.gmane.org/gmane.comp.gnu.lilypond.bugs/23117 This patch demonstrates the problem, describes the reason, and documents two ways of avoiding the problem. Please review this patch. I'm afraid I might have been a little too much LM style in it, although I didn't talk through the code. Thanks, Carl
Sign in to reply to this message.
I'd rather drop the first two examples illustrating the problem. It is stated clearly enough, and bad examples shouldn't appear in the docs. Otherwise it looks OK to me. Trevor http://codereview.appspot.com/4160048/diff/1/Documentation/notation/rhythms.i... File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4160048/diff/1/Documentation/notation/rhythms.i... Documentation/notation/rhythms.itely:2089: @code{Score} context. This means that a setting the time signature that setting (no "a") http://codereview.appspot.com/4160048/diff/1/Documentation/notation/rhythms.i... Documentation/notation/rhythms.itely:2092: beaming for 3/4 time, because the time signature setting in the Thus, in the following example, standard 3/4 beaming will be used in both staves, because ... http://codereview.appspot.com/4160048/diff/1/Documentation/notation/rhythms.i... Documentation/notation/rhythms.itely:2129: To avoid this problem, the time signature can be set in only one should be set http://codereview.appspot.com/4160048/diff/1/Documentation/notation/rhythms.i... Documentation/notation/rhythms.itely:2147: changed, so that when the time signature is set the desired whenever http://codereview.appspot.com/4160048/diff/1/Documentation/notation/rhythms.i... Documentation/notation/rhythms.itely:2158: #'() % beamExceptions tabs
Sign in to reply to this message.
On 2011/02/12 10:08:57, Trevor Daniels wrote: > I'd rather drop the first two examples illustrating the problem. It is stated > clearly enough, and bad examples shouldn't appear in the docs. Otherwise it > looks OK to me. I'd agree with Trevor's general point, for the NR anyway, I like to try to not say 'in this example...' or 'in the following example..\' and so on and then present an @lilypond. Just state the difference/behaviour and then the @lilypond. Less friendly (more LM) but to the point.
Sign in to reply to this message.
Why isn't this inside @knownissues ?
Sign in to reply to this message.
Updated patch set posted for review. THanks, Carl
Sign in to reply to this message.
LGTM.
Sign in to reply to this message.
http://codereview.appspot.com/4160048/diff/5001/Documentation/notation/rhythm... File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4160048/diff/5001/Documentation/notation/rhythm... Documentation/notation/rhythms.itely:2207: @code{Score} context. This means that a setting the time signature Should it be "This means that setting the time signature [...]"?
Sign in to reply to this message.
On 2011/02/15 00:27:35, Felipe wrote: > http://codereview.appspot.com/4160048/diff/5001/Documentation/notation/rhythm... > File Documentation/notation/rhythms.itely (right): > > http://codereview.appspot.com/4160048/diff/5001/Documentation/notation/rhythm... > Documentation/notation/rhythms.itely:2207: @code{Score} context. This means > that a setting the time signature > Should it be "This means that setting the time signature [...]"? Yes, thanks. Good catch!
Sign in to reply to this message.
LGTM, apart from a couple of niggles http://codereview.appspot.com/4160048/diff/5001/Documentation/notation/rhythm... File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4160048/diff/5001/Documentation/notation/rhythm... Documentation/notation/rhythms.itely:2211: To avoid this problem, the time signature can be set in only one I still prefer "should" http://codereview.appspot.com/4160048/diff/5001/Documentation/notation/rhythm... Documentation/notation/rhythms.itely:2229: changed, so that when the time signature is set the desired I still prefer "whenever"
Sign in to reply to this message.
On 2011/02/15 07:15:48, Trevor Daniels wrote: > http://codereview.appspot.com/4160048/diff/5001/Documentation/notation/rhythm... > Documentation/notation/rhythms.itely:2211: To avoid this problem, the time > signature can be set in only one > I still prefer "should" I don't want to say "should" because that can be interpreted as an "all the time" prescription. I've reworded it to say "One way to avoid this problem is to set the time signature in only one staff". I've thought about "when" vs. "whenever". I prefer "when". I don't know if it's a UK vs. US thing, or just a Carl vs. Trevor thing. Thanks, Carl
Sign in to reply to this message.
LGTM. I prefer not to fuss about @knownissues, so just push it when(ever) you think it's good enough. http://codereview.appspot.com/4160048/diff/11001/Documentation/notation/rhyth... File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4160048/diff/11001/Documentation/notation/rhyth... Documentation/notation/rhythms.itely:2229: changed, so that when the time signature is set the desired What about: ... changed, so that the desired beaming is always used for that time signature. ? then we avoid the dreaded "when" / "whenever".
Sign in to reply to this message.
<percival.music.ca@gmail.com> > http://codereview.appspot.com/4160048/diff/11001/Documentation/notation/rhyth... > Documentation/notation/rhythms.itely:2229: changed, so that when > the > time signature is set the desired > What about: > > ... changed, so that the desired beaming is always used for that > time > signature. > > ? then we avoid the dreaded "when" / "whenever". I'm happy with that. > http://codereview.appspot.com/4160048/ Trevor
Sign in to reply to this message.
<percival.music.ca@gmail.com> > http://codereview.appspot.com/4160048/diff/11001/Documentation/notation/rhyth... > Documentation/notation/rhythms.itely:2229: changed, so that when > the > time signature is set the desired > What about: > > ... changed, so that the desired beaming is always used for that > time > signature. > > ? then we avoid the dreaded "when" / "whenever". I'm happy with that. > http://codereview.appspot.com/4160048/ Trevor
Sign in to reply to this message.
|
