Issue 4157042: code review 4157042: http: handle unchunked, un-lengthed HTTP/1.1 responses

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4157042: code review 4157042: http: handle unchunked, un-lengthed HTTP/1.1 responses (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by bradfitz

Modified:
14 years, 4 months ago

Reviewers:

CC:
rsc, petar-m, dsymonds, golang-dev

Visibility:
Public.

Description

http: handle unchunked, un-lengthed HTTP/1.1 responses Fixes issue 716 This CL simply resumes the previous CL in-flight at http://codereview.appspot.com/906042/

Patch Set 2 : code review 4157042: http: handle unchunked, un-lengthed HTTP/1.1 responses #

Total comments: 3

Patch Set 3 : diff -r 6d628a8b59bf https://go.googlecode.com/hg #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -0 lines)			Patch
	M	src/pkg/http/response_test.go	View		1 chunk	+41 lines, -0 lines	0 comments	Download
	M	src/pkg/http/transfer.go	View		2 chunks	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello rsc, petar-m (cc: dsymonds, golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 4 months ago (2011-02-08 23:26:10 UTC) #1

dsymonds

LGTM http://codereview.appspot.com/4157042/diff/2001/src/pkg/http/transfer.go File src/pkg/http/transfer.go (right): http://codereview.appspot.com/4157042/diff/2001/src/pkg/http/transfer.go#newcode239 src/pkg/http/transfer.go:239: if t.ContentLength == -1 && I'd probably join ...

14 years, 4 months ago (2011-02-08 23:37:16 UTC) #2

rsc

LGTM http://codereview.appspot.com/4157042/diff/2001/src/pkg/http/response.go File src/pkg/http/response.go (right): http://codereview.appspot.com/4157042/diff/2001/src/pkg/http/response.go#newcode61 src/pkg/http/response.go:61: // Close records whether the headers directed that ...

14 years, 4 months ago (2011-02-08 23:51:42 UTC) #3

bradfitz

14 years, 4 months ago (2011-02-09 04:35:05 UTC) #4

*** Submitted as 13fc96e06ca6 ***

http: handle unchunked, un-lengthed HTTP/1.1 responses

Fixes issue 716

This CL simply resumes the previous CL in-flight at
http://codereview.appspot.com/906042/

R=rsc, petar-m, dsymonds
CC=golang-dev
http://codereview.appspot.com/4157042

Expand All Messages | Collapse All Messages