Issue 4154043: code review 4154043: cgen64: dont use MVN instruction

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4154043: code review 4154043: cgen64: dont use MVN instruction (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by ken3

Modified:
14 years, 4 months ago

Reviewers:
r2

CC:
r, golang-dev

Visibility:
Public.

Description

cgen64: dont use MVN instruction

Patch Set 1 #

Patch Set 2 : diff -r b8ecb3a4c34b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b8ecb3a4c34b https://go.googlecode.com/hg/ #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -20 lines)			Patch
	M	src/cmd/5g/cgen64.c	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
	M	src/cmd/5g/peep.c	View	1	5 chunks	+18 lines, -18 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ken3

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 4 months ago (2011-02-09 01:30:22 UTC) #1

ken3

*** Submitted as http://code.google.com/p/go/source/detail?r=669162f2c3e8 *** cgen64: dont use MVN instruction R=r CC=golang-dev http://codereview.appspot.com/4154043

14 years, 4 months ago (2011-02-09 01:30:26 UTC) #2

LGTM

Expand All Messages | Collapse All Messages