Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4760)

Issue 4149045: Doc: NR accidental styles (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by Keith
Modified:
13 years, 2 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR accidental styles Document effect of set-accidental-style on extraNatural Remove deprecated snippet Remove incorrect text

Patch Set 1 : DOC: update automatic accidentals #

Total comments: 4

Patch Set 2 : show not tell #

Total comments: 2

Patch Set 3 : remove mention of @code{extraNatural} #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -140 lines) Patch
M Documentation/de/notation/pitches.itely View 1 chunk +0 lines, -6 lines 0 comments Download
M Documentation/es/notation/pitches.itely View 1 chunk +0 lines, -6 lines 0 comments Download
M Documentation/fr/notation/pitches.itely View 1 chunk +0 lines, -6 lines 0 comments Download
M Documentation/notation/pitches.itely View 1 2 19 chunks +22 lines, -26 lines 0 comments Download
D Documentation/snippets/dodecaphonic-style-accidentals-for-each-note-including-naturals.ly View 1 chunk +0 lines, -72 lines 0 comments Download
D Documentation/snippets/new/dodecaphonic-style-accidentals-for-each-note-including-naturals.ly View 1 1 chunk +0 lines, -23 lines 0 comments Download
M Documentation/snippets/pitches.snippet-list View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7
Keith
http://codereview.appspot.com/4149045/diff/6001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (left): http://codereview.appspot.com/4149045/diff/6001/Documentation/notation/pitches.itely#oldcode2261 Documentation/notation/pitches.itely:2261: the music. Unlike @code{dodecaphonic}, this rule never prints Acutally, ...
13 years, 2 months ago (2011-02-09 09:37:16 UTC) #1
Graham Percival (old account)
http://codereview.appspot.com/4149045/diff/6001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/4149045/diff/6001/Documentation/notation/pitches.itely#newcode2313 Documentation/notation/pitches.itely:2313: signs. For example, a natural is printed before a ...
13 years, 2 months ago (2011-02-23 04:23:44 UTC) #2
Keith
On 2011/02/23 04:23:44, Graham Percival wrote: > On 2011/02/09 09:37:16, Keith wrote: > > I ...
13 years, 2 months ago (2011-02-24 02:41:27 UTC) #3
Graham Percival (old account)
It's still not showy enough for me. http://codereview.appspot.com/4149045/diff/9001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/4149045/diff/9001/Documentation/notation/pitches.itely#newcode2527 Documentation/notation/pitches.itely:2527: Several accidental ...
13 years, 2 months ago (2011-02-24 06:32:25 UTC) #4
Keith
On 2011/02/24 06:32:25, Graham Percival wrote: > It's still not showy enough for me. > ...
13 years, 2 months ago (2011-02-24 18:46:41 UTC) #5
Graham Percival (old account)
LGTM
13 years, 2 months ago (2011-02-25 05:36:52 UTC) #6
Trevor Daniels
13 years, 2 months ago (2011-02-25 22:46:46 UTC) #7
LGTM

Trevor
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b