http://codereview.appspot.com/4149045/diff/6001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (left): http://codereview.appspot.com/4149045/diff/6001/Documentation/notation/pitches.itely#oldcode2261 Documentation/notation/pitches.itely:2261: the music. Unlike @code{dodecaphonic}, this rule never prints Acutally, ...
13 years, 2 months ago
(2011-02-09 09:37:16 UTC)
#1
http://codereview.appspot.com/4149045/diff/6001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/4149045/diff/6001/Documentation/notation/pitches.itely#newcode2313 Documentation/notation/pitches.itely:2313: signs. For example, a natural is printed before a ...
13 years, 2 months ago
(2011-02-23 04:23:44 UTC)
#2
http://codereview.appspot.com/4149045/diff/6001/Documentation/notation/pitche...
File Documentation/notation/pitches.itely (right):
http://codereview.appspot.com/4149045/diff/6001/Documentation/notation/pitche...
Documentation/notation/pitches.itely:2313: signs. For example, a natural is
printed before a C-sharp
On 2011/02/09 09:37:16, Keith wrote:
> I thought about making the @lilyponds above show this effect, but they are
> already quite information-dense.
> 'Extra' naturals come up relatively rarely, and the choice to print them /can/
> be made independently from the accidental-style, so it seems best to mention
> them in a separate paragraph.
I disagree. Please alter the above examples -- it's really easy to
misunderstand a textual description of accidentals, especially if English is
your second or third language. "show, don't tell".
http://codereview.appspot.com/4149045/diff/6001/Documentation/snippets/dodeca...
File
Documentation/snippets/dodecaphonic-style-accidentals-for-each-note-including-naturals.ly
(left):
http://codereview.appspot.com/4149045/diff/6001/Documentation/snippets/dodeca...
Documentation/snippets/dodecaphonic-style-accidentals-for-each-note-including-naturals.ly:2:
% generated from Documentation/snippets/new
This file is auto-generated from D/s/n. Have you removed it from there?
On 2011/02/23 04:23:44, Graham Percival wrote: > On 2011/02/09 09:37:16, Keith wrote: > > I ...
13 years, 2 months ago
(2011-02-24 02:41:27 UTC)
#3
On 2011/02/23 04:23:44, Graham Percival wrote:
> On 2011/02/09 09:37:16, Keith wrote:
> > I thought about making the @lilyponds above show this effect, but
> > [...]
> I disagree. Please alter the above examples
Put differently, you agree more with my initial instinct.
New patch set is up.
It's still not showy enough for me. http://codereview.appspot.com/4149045/diff/9001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/4149045/diff/9001/Documentation/notation/pitches.itely#newcode2527 Documentation/notation/pitches.itely:2527: Several accidental ...
13 years, 2 months ago
(2011-02-24 06:32:25 UTC)
#4
It's still not showy enough for me.
http://codereview.appspot.com/4149045/diff/9001/Documentation/notation/pitche...
File Documentation/notation/pitches.itely (right):
http://codereview.appspot.com/4149045/diff/9001/Documentation/notation/pitche...
Documentation/notation/pitches.itely:2527: Several accidental styles,
@code{modern} through @code{teaching}
Why are you telling me this?
If you want me to know that some style suppresses printing an extra natural,
then show me in the output of the @lilypond.
http://codereview.appspot.com/4149045/diff/9001/Documentation/notation/pitche...
Documentation/notation/pitches.itely:2530: For different behavior,
@code{extraNatural} may be set as desired,
Never ever say "@code{blah} may be set".
Let's get the patch pushed with showing the accidentals without extra naturals
and without any discussion of extraNatural. Then, in a second patch, let's have
a snippet that shows how to force extra natural signs to appear. You could
either do this in LSR itself, or in Documentation/snippets/new/.
On 2011/02/24 06:32:25, Graham Percival wrote: > It's still not showy enough for me. > ...
13 years, 2 months ago
(2011-02-24 18:46:41 UTC)
#5
On 2011/02/24 06:32:25, Graham Percival wrote:
> It's still not showy enough for me.
>
Well, maybe it's showy enough to resolve issue 1399. I posted the output images
of the examples to that tracker item.
http://code.google.com/p/lilypond/issues/detail?id=1399
> Documentation/notation/pitches.itely:2527: Several accidental styles,
> @code{modern} through @code{teaching}
> Why are you telling me this?
>
Just as a segue into @ref{Accidentals}, where we have the snippet showing how to
set extraNatural.
>Let's get the patch pushed with showing the accidentals without extra naturals
> and without any discussion of extraNatural.
New patch is up. Will wait a couple more days before pushing.
Issue 4149045: Doc: NR accidental styles
(Closed)
Created 13 years, 2 months ago by Keith
Modified 13 years, 2 months ago
Reviewers: Graham Percival (old account), Trevor Daniels
Base URL:
Comments: 6