code review 4145043: go spec: clarification re: method sets of newly declare...

go spec: clarification re: method sets of newly declared pointer types

- added an example to Type declarations section clarifying the
  situation brought up with issue 1324
- slightly re-ordered paragraphs in Types section
- added separate heading for method set section and refer to it
  from elsewhere in the spec
- no language changes

[gri, 2011-02-08 18:27:34]

Hello rsc, r, iant, ken2 (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[iant, 2011-02-08 21:00:17]

LGTM

[rsc, 2011-02-08 21:11:54]

LGTM

http://codereview.appspot.com/4145043/diff/4001/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/4145043/diff/4001/doc/go_spec.html#newcode613
doc/go_spec.html:613: The <i>static type</i> (or just <i>type</i>) of a variable
is the
You say variable here, but this applies to struct fields,
map entries, slice entries, dereferenced pointers, and so on.
Should it be value?

[r2, 2011-02-08 21:21:46]

On Feb 8, 2011, at 1:11 PM, rsc@golang.org wrote:

> LGTM
> 
> 
> 
> http://codereview.appspot.com/4145043/diff/4001/doc/go_spec.html
> File doc/go_spec.html (right):
> 
> http://codereview.appspot.com/4145043/diff/4001/doc/go_spec.html#newcode613
> doc/go_spec.html:613: The <i>static type</i> (or just <i>type</i>) of a
> variable is the
> You say variable here, but this applies to struct fields,
> map entries, slice entries, dereferenced pointers, and so on.
> Should it be value?

robert's collective word for these things is 'variable'.

-rob

[gri, 2011-02-08 21:22:50]

http://codereview.appspot.com/4145043/diff/4001/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/4145043/diff/4001/doc/go_spec.html#newcode613
doc/go_spec.html:613: The <i>static type</i> (or just <i>type</i>) of a variable
is the
On 2011/02/08 21:11:54, rsc wrote:
> You say variable here, but this applies to struct fields,
> map entries, slice entries, dereferenced pointers, and so on.
> Should it be value?

I'd rather not change this in this CL as this is the same text as before and if
it is changed, it may have to change elsewhere.

(This is a long-standing debate between r and I. To me, a memory location that
can be accessed with (safe) Go is a variable. Some variables have names, some
are denoted via operands, etc. With this notion of "variable" this section is
correct; and several other sections could probably be simplified. As it is, we
have to enumerate all operands that denote such variables. Which one is the
right one is debatable - let's not do this in this CL.)

[rsc, 2011-02-08 21:24:09]

OK

On Tue, Feb 8, 2011 at 16:22,  <gri@golang.org> wrote:
>
> http://codereview.appspot.com/4145043/diff/4001/doc/go_spec.html
> File doc/go_spec.html (right):
>
> http://codereview.appspot.com/4145043/diff/4001/doc/go_spec.html#newcode613
> doc/go_spec.html:613: The <i>static type</i> (or just <i>type</i>) of a
> variable is the
> On 2011/02/08 21:11:54, rsc wrote:
>>
>> You say variable here, but this applies to struct fields,
>> map entries, slice entries, dereferenced pointers, and so on.
>> Should it be value?
>
> I'd rather not change this in this CL as this is the same text as before
> and if it is changed, it may have to change elsewhere.
>
> (This is a long-standing debate between r and I. To me, a memory
> location that can be accessed with (safe) Go is a variable. Some
> variables have names, some are denoted via operands, etc. With this
> notion of "variable" this section is correct; and several other sections
> could probably be simplified. As it is, we have to enumerate all
> operands that denote such variables. Which one is the right one is
> debatable - let's not do this in this CL.)
>
> http://codereview.appspot.com/4145043/
>

[eh, 2011-02-08 21:31:01]

On 8 February 2011 21:21, Rob 'Commander' Pike <r@google.com> wrote:
>
> On Feb 8, 2011, at 1:11 PM, rsc@golang.org wrote:
>
>> LGTM
>>
>>
>>
>> http://codereview.appspot.com/4145043/diff/4001/doc/go_spec.html
>> File doc/go_spec.html (right):
>>
>> http://codereview.appspot.com/4145043/diff/4001/doc/go_spec.html#newcode613
>> doc/go_spec.html:613: The <i>static type</i> (or just <i>type</i>) of a
>> variable is the
>> You say variable here, but this applies to struct fields,
>> map entries, slice entries, dereferenced pointers, and so on.
>> Should it be value?
>
> robert's collective word for these things is 'variable'.

How about "location"?

Chris

-- 
Chris "lvalues, but not as C has them" Dollin

[gri, 2011-02-08 21:31:04]

*** Submitted as http://code.google.com/p/go/source/detail?r=a92de010b83d ***

go spec: clarification re: method sets of newly declared pointer types

- added an example to Type declarations section clarifying the
  situation brought up with issue 1324
- slightly re-ordered paragraphs in Types section
- added separate heading for method set section and refer to it
  from elsewhere in the spec
- no language changes

R=rsc, r, iant, ken2, r2
CC=golang-dev
http://codereview.appspot.com/4145043